Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: trunk/src/content/child/fileapi/webfilewriter_impl.cc

Issue 22300004: Revert 215787 "Support synchronous mode in WebFileWriterImpl" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/content/child/fileapi/webfilewriter_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/child/fileapi/webfilewriter_impl.cc
===================================================================
--- trunk/src/content/child/fileapi/webfilewriter_impl.cc (revision 215792)
+++ trunk/src/content/child/fileapi/webfilewriter_impl.cc (working copy)
@@ -6,7 +6,6 @@
#include "base/bind.h"
#include "base/platform_file.h"
-#include "base/synchronization/waitable_event.h"
#include "content/child/child_thread.h"
#include "content/child/fileapi/file_system_dispatcher.h"
#include "webkit/child/worker_task_runner.h"
@@ -32,13 +31,9 @@
class WebFileWriterImpl::WriterBridge
: public base::RefCountedThreadSafe<WriterBridge> {
public:
- WriterBridge(WebFileWriterImpl::Type type)
+ WriterBridge()
: request_id_(0),
- thread_id_(WorkerTaskRunner::Instance()->CurrentWorkerId()),
- written_bytes_(0) {
- if (type == WebFileWriterImpl::TYPE_SYNC)
- waitable_event_.reset(new base::WaitableEvent(false, false));
- }
+ thread_id_(WorkerTaskRunner::Instance()->CurrentWorkerId()) {}
void Truncate(const GURL& path, int64 offset,
const StatusCallback& status_callback) {
@@ -72,26 +67,12 @@
base::Bind(&WriterBridge::DidFinish, this));
}
- base::WaitableEvent* waitable_event() {
- return waitable_event_.get();
- }
-
- void WaitAndRun() {
- waitable_event_->Wait();
- DCHECK(!results_closure_.is_null());
- results_closure_.Run();
- written_bytes_ = 0;
- }
-
private:
friend class base::RefCountedThreadSafe<WriterBridge>;
virtual ~WriterBridge() {}
void DidWrite(int64 bytes, bool complete) {
- written_bytes_ += bytes;
- if (waitable_event_ && !complete)
- return;
- PostTaskToWorker(base::Bind(write_callback_, written_bytes_, complete));
+ PostTaskToWorker(base::Bind(write_callback_, bytes, complete));
}
void DidFinish(base::PlatformFileError status) {
@@ -99,36 +80,24 @@
}
void PostTaskToWorker(const base::Closure& closure) {
- if (!thread_id_) {
- DCHECK(!waitable_event_);
+ if (!thread_id_)
closure.Run();
- return;
- }
- if (waitable_event_) {
- results_closure_ = closure;
- waitable_event_->Signal();
- return;
- }
- WorkerTaskRunner::Instance()->PostTask(thread_id_, closure);
- written_bytes_ = 0;
+ else
+ WorkerTaskRunner::Instance()->PostTask(thread_id_, closure);
}
StatusCallback status_callback_;
WriteCallback write_callback_;
int request_id_;
int thread_id_;
- int written_bytes_;
- scoped_ptr<base::WaitableEvent> waitable_event_;
- base::Closure results_closure_;
};
WebFileWriterImpl::WebFileWriterImpl(
const GURL& path, WebKit::WebFileWriterClient* client,
- Type type,
base::MessageLoopProxy* main_thread_loop)
: WebFileWriterBase(path, client),
main_thread_loop_(main_thread_loop),
- bridge_(new WriterBridge(type)) {
+ bridge_(new WriterBridge) {
}
WebFileWriterImpl::~WebFileWriterImpl() {
@@ -154,14 +123,10 @@
}
void WebFileWriterImpl::RunOnMainThread(const base::Closure& closure) {
- if (main_thread_loop_->RunsTasksOnCurrentThread()) {
- DCHECK(!bridge_->waitable_event());
+ if (main_thread_loop_->RunsTasksOnCurrentThread())
closure.Run();
- return;
- }
- main_thread_loop_->PostTask(FROM_HERE, closure);
- if (bridge_->waitable_event())
- bridge_->WaitAndRun();
+ else
+ main_thread_loop_->PostTask(FROM_HERE, closure);
}
} // namespace content
« no previous file with comments | « trunk/src/content/child/fileapi/webfilewriter_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698