Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/precache/core/proto/precache.proto

Issue 2229983002: Send the list of used and unused resources for precache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, removed timestamp from proto Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/core/proto/precache.proto
diff --git a/components/precache/core/proto/precache.proto b/components/precache/core/proto/precache.proto
index 9bdd7af9b5cf1e9d8afef82f1a4c157328d5e089..5e6850af92aa4593a26f87490cca29711792c1f9 100644
--- a/components/precache/core/proto/precache.proto
+++ b/components/precache/core/proto/precache.proto
@@ -13,6 +13,14 @@ option optimize_for = LITE_RUNTIME;
message PrecacheResource {
// The URL of the resource. This field must always be present.
optional string url = 1;
+
+ // The tophost this resource corresponds to.
+ optional string top_host_name = 2;
+};
+
+message PrecacheManifestId {
+ // Time at the creation of this manifest.
sclittle 2016/08/16 21:05:06 nit: Remove this comment - ideally, this ID should
Raj 2016/08/18 00:23:24 Yes. I missed removing it.
+ optional int64 id = 1;
};
// A manifest of cacheable resources to be precached for a specific host.
@@ -23,13 +31,16 @@ message PrecacheManifest {
// Experiments running on this manifest.
optional PrecacheExperiments experiments = 2;
+
+ // Identifier for the manifest sent by the server.
+ optional PrecacheManifestId id = 3;
};
message PrecacheExperiments {
// A mapping between experiment groups and the resources that should be
// considered for the experiment.
map<fixed32, PrecacheResourceSelection> resources_by_experiment_group = 1;
-}
+};
message PrecacheResourceSelection {
// Select the resources as a std::bitset over the resources listed in the
@@ -42,7 +53,7 @@ message PrecacheResourceSelection {
//
// A missing bitset means that the experiment applies to all the resources.
optional fixed64 bitset = 1 [default = 0xFFFFFFFFFFFFFFFF];
-}
+};
message PrecacheConfigurationSettings {
// The maximum rank of the user's most visited hosts to consider precaching

Powered by Google App Engine
This is Rietveld 408576698