Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: components/precache/core/proto/precache.proto

Issue 2229983002: Send the list of used and unused resources for precache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/core/proto/precache.proto
diff --git a/components/precache/core/proto/precache.proto b/components/precache/core/proto/precache.proto
index 9bdd7af9b5cf1e9d8afef82f1a4c157328d5e089..1e5ac3972e46cfe6b3bed6e27972ce8f827f2637 100644
--- a/components/precache/core/proto/precache.proto
+++ b/components/precache/core/proto/precache.proto
@@ -4,6 +4,8 @@
syntax = "proto2";
+import "timestamp.proto";
+
package precache;
// Chrome requires this.
@@ -13,8 +15,16 @@ option optimize_for = LITE_RUNTIME;
message PrecacheResource {
// The URL of the resource. This field must always be present.
optional string url = 1;
+
+ // The tophost this resource corresponds to.
+ optional string tophostname = 2;
sclittle 2016/08/11 22:52:36 nit: maybe change to top_host_name?
Raj 2016/08/12 19:04:21 Done.
};
+message PrecacheManifestId {
+ // Time at the creation of this manifest.
sclittle 2016/08/11 22:52:36 What determines this time? The server? If so, then
Raj 2016/08/12 19:04:22 The manifest_id(timestamp) is just an opaque data
+ optional Timestamp timestamp = 1;
sclittle 2016/08/11 22:52:36 Why is this specifically a timestamp? Could this j
Raj 2016/08/12 19:04:22 I will try to change this manifest_id to a simple
+}
+
// A manifest of cacheable resources to be precached for a specific host.
message PrecacheManifest {
// List of resources that we predict that the user will need if they are
@@ -23,6 +33,8 @@ message PrecacheManifest {
// Experiments running on this manifest.
optional PrecacheExperiments experiments = 2;
+
+ optional PrecacheManifestId id = 3;
bengr 2016/08/11 18:49:15 Add a comment.
Raj 2016/08/12 19:04:21 Done.
};
message PrecacheExperiments {

Powered by Google App Engine
This is Rietveld 408576698