Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/precache/core/precache_database_unittest.cc

Issue 2229983002: Send the list of used and unused resources for precache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/core/precache_database_unittest.cc
diff --git a/components/precache/core/precache_database_unittest.cc b/components/precache/core/precache_database_unittest.cc
index a4e7e4651b957759b0d294a5f7d67cc96813b372..a158c07ef05096c76ba7b4cec10d394feb7354d1 100644
--- a/components/precache/core/precache_database_unittest.cc
+++ b/components/precache/core/precache_database_unittest.cc
@@ -32,6 +32,7 @@ using base::Bucket;
using net::HttpResponseInfo;
const GURL kURL("http://url.com");
+const int kReferrerID = 1;
const base::TimeDelta kLatency = base::TimeDelta::FromMilliseconds(5);
const base::Time kFetchTime = base::Time() + base::TimeDelta::FromHours(1000);
const base::Time kOldFetchTime = kFetchTime - base::TimeDelta::FromDays(1);
@@ -168,7 +169,9 @@ void PrecacheDatabaseTest::RecordPrecacheFromNetwork(
int64_t size) {
const HttpResponseInfo info = CreateHttpResponseInfo(
false /* was_cached */, false /* network_accessed */);
- precache_database_->RecordURLPrefetch(url, latency, fetch_time, info, size);
+ precache_database_->RecordURLPrefetchMetrics(info, latency);
+ precache_database_->RecordURLPrefetch(url, std::string(), fetch_time,
+ info.was_cached, size);
}
void PrecacheDatabaseTest::RecordPrecacheFromCache(const GURL& url,
@@ -176,8 +179,10 @@ void PrecacheDatabaseTest::RecordPrecacheFromCache(const GURL& url,
int64_t size) {
const HttpResponseInfo info = CreateHttpResponseInfo(
true /* was_cached */, false /* network_accessed */);
- precache_database_->RecordURLPrefetch(url, base::TimeDelta() /* latency */,
- fetch_time, info, size);
+ precache_database_->RecordURLPrefetchMetrics(info,
+ base::TimeDelta() /* latency */);
+ precache_database_->RecordURLPrefetch(url, std::string(), fetch_time,
+ info.was_cached, size);
}
void PrecacheDatabaseTest::RecordFetchFromNetwork(const GURL& url,
@@ -250,7 +255,7 @@ TEST_F(PrecacheDatabaseTest, PrecacheOverNetwork) {
}
TEST_F(PrecacheDatabaseTest, PrecacheFromCacheWithURLTableEntry) {
- precache_url_table()->AddURL(kURL, kOldFetchTime);
+ precache_url_table()->AddURL(kURL, kReferrerID, true, kOldFetchTime);
RecordPrecacheFromCache(kURL, kFetchTime, kSize);
// The URL table entry should have been updated to have |kFetchTime| as the
@@ -313,7 +318,7 @@ TEST_F(PrecacheDatabaseTest, FetchOverNetwork_Cellular) {
}
TEST_F(PrecacheDatabaseTest, FetchOverNetworkWithURLTableEntry) {
- precache_url_table()->AddURL(kURL, kOldFetchTime);
+ precache_url_table()->AddURL(kURL, kReferrerID, true, kOldFetchTime);
RecordFetchFromNetwork(kURL, kLatency, kFetchTime, kSize);
// The URL table entry should have been deleted.
@@ -328,7 +333,7 @@ TEST_F(PrecacheDatabaseTest, FetchOverNetworkWithURLTableEntry) {
}
TEST_F(PrecacheDatabaseTest, FetchFromCacheWithURLTableEntry_NonCellular) {
- precache_url_table()->AddURL(kURL, kOldFetchTime);
+ precache_url_table()->AddURL(kURL, kReferrerID, true, kOldFetchTime);
RecordFetchFromCache(kURL, kFetchTime, kSize);
// The URL table entry should have been deleted.
@@ -344,7 +349,7 @@ TEST_F(PrecacheDatabaseTest, FetchFromCacheWithURLTableEntry_NonCellular) {
}
TEST_F(PrecacheDatabaseTest, FetchFromCacheWithURLTableEntry_Cellular) {
- precache_url_table()->AddURL(kURL, kOldFetchTime);
+ precache_url_table()->AddURL(kURL, kReferrerID, true, kOldFetchTime);
RecordFetchFromCacheCellular(kURL, kFetchTime, kSize);
// The URL table entry should have been deleted.
@@ -377,8 +382,10 @@ TEST_F(PrecacheDatabaseTest, DeleteExpiredPrecacheHistory) {
const base::Time k59DaysAgo = kToday - base::TimeDelta::FromDays(59);
const base::Time k61DaysAgo = kToday - base::TimeDelta::FromDays(61);
- precache_url_table()->AddURL(GURL("http://expired-precache.com"), k61DaysAgo);
- precache_url_table()->AddURL(GURL("http://old-precache.com"), k59DaysAgo);
+ precache_url_table()->AddURL(GURL("http://expired-precache.com"), kReferrerID,
+ true, k61DaysAgo);
+ precache_url_table()->AddURL(GURL("http://old-precache.com"), kReferrerID,
+ true, k59DaysAgo);
precache_database_->DeleteExpiredPrecacheHistory(kToday);

Powered by Google App Engine
This is Rietveld 408576698