Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2229973002: Revert: Fixes memory leaks in the eventhandler (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert: Fixes memory leaks in the eventhandler For bot crashes on Mac Committed: https://github.com/dart-lang/sdk/commit/bf085120f67a398ec7ad652133d1fe4f9d407f25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -113 lines) Patch
M runtime/bin/eventhandler.h View 7 chunks +5 lines, -19 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/socket.h View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/bin/socket.cc View 1 chunk +31 lines, -46 lines 0 comments Download
M runtime/platform/hashmap.h View 3 chunks +2 lines, -9 lines 0 comments Download
M runtime/platform/hashmap.cc View 4 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years, 4 months ago (2016-08-09 22:36:44 UTC) #2
zra
TBR
4 years, 4 months ago (2016-08-09 22:36:50 UTC) #3
zra
Committed patchset #1 (id:1) manually as bf085120f67a398ec7ad652133d1fe4f9d407f25 (presubmit successful).
4 years, 4 months ago (2016-08-09 22:37:03 UTC) #5
zra
4 years, 4 months ago (2016-08-09 23:26:49 UTC) #7
Message was sent while issue was closed. 
On 2016/08/09 22:37:03, zra wrote:
> Committed patchset #1 (id:1) manually as
> bf085120f67a398ec7ad652133d1fe4f9d407f25 (presubmit successful).

NB: This issue had the wrong title, but it is a revert of the correct change.

Powered by Google App Engine
This is Rietveld 408576698