chrome/browser/chrome_content_browser_client.cc - Issue 2229943003: Reusing Ok/Cancel buttons for intent picker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2229943003: Reusing Ok/Cancel buttons for intent picker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Temporary fix to force Layout enabling within contents_viewport_ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 588337784109a69113d20b972f4b611642ef59a6..a9d2ebf79146cf9cb7799d3e7ed2aff5b6ba73f7 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -3131,8 +3131,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(

throttles.push_back(MergeSessionNavigationThrottle::Create(handle));

}

- // TODO(djacobo): Support incognito mode by showing an aditional dialog as a

- // warning that the selected app is not in incognito mode.

const arc::ArcAuthService* auth_service = arc::ArcAuthService::Get();

if (auth_service && auth_service->IsArcEnabled() &&

!handle->GetWebContents()->GetBrowserContext()->IsOffTheRecord()) {