Reusing Ok/Cancel buttons for intent picker

ui/views/controls/scroll_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/scroll_view.h"
 
 #include "base/feature_list.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "ui/events/event.h"
@@ skipping 665 matching lines @@
     ScrollHeader();
   }
 }
 
 bool ScrollView::ScrollsWithLayers() const {
   // Just check for the presence of a layer since it's cheaper than querying the
   // Feature flag each time.
   return contents_viewport_->layer() != nullptr;
 }
 
+void ScrollView::ActivateLayer(bool force_layer_creation) {

[sky, 2016/10/14 22:59:27]

This name is mildly confusing and why does it take a boolean and have the checks
below? You only call it in one place and with true. How about calling it
EnableViewportLayer()? Also, please file a bug that it shouldn't be necessary
with a TODO referencing said bug.

[djacobo_, 2016/10/14 23:35:32]

I am still trying to figure out how to do the proper fix, so I was basically
mixing both ideas, sorry for the confusion. I will get rid of
ChildrenLayerCheck() for now and set this temporary fix. Done.

+  if (force_layer_creation || ChildrenLayerCheck(contents_viewport_)) {
+    background_color_ = SK_ColorWHITE;
+    contents_viewport_->set_background(
+        Background::CreateSolidBackground(background_color_));
+    contents_viewport_->SetPaintToLayer(true);
+    contents_viewport_->layer()->SetMasksToBounds(true);
+  }
+}
+
+bool ScrollView::ChildrenLayerCheck(View* child) const {
+  if (!child)
+    return false;
+  if (child->layer() != nullptr)
+    return true;
+
+  for (int i = 0; i < child->child_count(); ++i)
+    if (ChildrenLayerCheck(child->child_at(i)))
+      return true;
+  return false;
+}
+
 void ScrollView::OnLayerScrolled() {
   UpdateScrollBarPositions();
   ScrollHeader();
 }
 
 void ScrollView::ScrollHeader() {
   if (!header_)
     return;
 
   int x_offset = CurrentOffset().x();
@@ skipping 70 matching lines @@
 
 VariableRowHeightScrollHelper::RowInfo
     FixedRowHeightScrollHelper::GetRowInfo(int y) {
   if (y < top_margin_)
     return RowInfo(0, top_margin_);
   return RowInfo((y - top_margin_) / row_height_ * row_height_ + top_margin_,
                  row_height_);
 }
 
 }  // namespace views