Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Side by Side Diff: chrome/browser/ui/views/intent_picker_bubble_view_unittest.cc

Issue 2229943003: Reusing Ok/Cancel buttons for intent picker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing the intent picker class to use is_null() and Reset() properly. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/intent_picker_bubble_view.h" 5 #include "chrome/browser/ui/views/intent_picker_bubble_view.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h" 11 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h"
12 #include "chrome/test/base/browser_with_test_window_test.h" 12 #include "chrome/test/base/browser_with_test_window_test.h"
13 #include "content/public/browser/web_contents.h" 13 #include "content/public/browser/web_contents.h"
14 #include "ui/base/resource/resource_bundle.h" 14 #include "ui/base/resource/resource_bundle.h"
15 #include "ui/gfx/image/image.h" 15 #include "ui/gfx/image/image.h"
16 #include "ui/views/controls/button/button.h" 16 #include "ui/views/controls/button/button.h"
17 #include "ui/views/controls/button/label_button.h"
18 #include "ui/views/controls/scroll_view.h" 17 #include "ui/views/controls/scroll_view.h"
19 #include "ui/views/resources/grit/views_resources.h" 18 #include "ui/views/resources/grit/views_resources.h"
20 #include "url/gurl.h" 19 #include "url/gurl.h"
21 20
22 using NameAndIcon = arc::ArcNavigationThrottle::NameAndIcon; 21 using NameAndIcon = arc::ArcNavigationThrottle::NameAndIcon;
23 using content::WebContents; 22 using content::WebContents;
24 using content::OpenURLParams; 23 using content::OpenURLParams;
25 using content::Referrer; 24 using content::Referrer;
26 25
27 class IntentPickerBubbleViewTest : public BrowserWithTestWindowTest { 26 class IntentPickerBubbleViewTest : public BrowserWithTestWindowTest {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 71
73 private: 72 private:
74 DISALLOW_COPY_AND_ASSIGN(IntentPickerBubbleViewTest); 73 DISALLOW_COPY_AND_ASSIGN(IntentPickerBubbleViewTest);
75 }; 74 };
76 75
77 // Verifies that we didn't set up an image for any LabelButton. 76 // Verifies that we didn't set up an image for any LabelButton.
78 TEST_F(IntentPickerBubbleViewTest, NullIcons) { 77 TEST_F(IntentPickerBubbleViewTest, NullIcons) {
79 CreateBubbleView(false); 78 CreateBubbleView(false);
80 size_t size = bubble_->app_info_.size(); 79 size_t size = bubble_->app_info_.size();
81 for (size_t i = 0; i < size; ++i) { 80 for (size_t i = 0; i < size; ++i) {
82 views::LabelButton* app = bubble_->GetLabelButtonAt(i); 81 gfx::ImageSkia image = bubble_->GetAppImageForTesting(i);
83 EXPECT_TRUE( 82 EXPECT_TRUE(image.isNull()) << i;
84 app->GetImage(views::Button::ButtonState::STATE_NORMAL).isNull()) << i;
85 } 83 }
86 } 84 }
87 85
88 // Verifies that all the icons contain a non-null icon. 86 // Verifies that all the icons contain a non-null icon.
89 TEST_F(IntentPickerBubbleViewTest, NonNullIcons) { 87 TEST_F(IntentPickerBubbleViewTest, NonNullIcons) {
90 CreateBubbleView(true); 88 CreateBubbleView(true);
91 size_t size = bubble_->app_info_.size(); 89 size_t size = bubble_->app_info_.size();
92 for (size_t i = 0; i < size; ++i) { 90 for (size_t i = 0; i < size; ++i) {
93 views::LabelButton* app = bubble_->GetLabelButtonAt(i); 91 gfx::ImageSkia image = bubble_->GetAppImageForTesting(i);
94 EXPECT_FALSE( 92 EXPECT_FALSE(image.isNull()) << i;
95 app->GetImage(views::Button::ButtonState::STATE_NORMAL).isNull()) << i;
96 } 93 }
97 } 94 }
98 95
99 // Verifies that the bubble contains as many rows as the input. Populated the 96 // Verifies that the bubble contains as many rows as the input. Populated the
100 // bubble with an arbitrary image in every row. 97 // bubble with an arbitrary image in every row.
101 TEST_F(IntentPickerBubbleViewTest, LabelsPtrVectorSize) { 98 TEST_F(IntentPickerBubbleViewTest, LabelsPtrVectorSize) {
102 CreateBubbleView(true); 99 CreateBubbleView(true);
103 EXPECT_EQ(app_info_.size(), bubble_->app_info_.size()); 100 EXPECT_EQ(app_info_.size(), bubble_->app_info_.size());
104 } 101 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698