Reusing Ok/Cancel buttons for intent picker

chrome/browser/ui/views/intent_picker_bubble_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.

[Yusuke Sato, 2016/08/17 23:18:21]

Can you also mention that this CL adds the hovering effect?

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_INTENT_PICKER_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_INTENT_PICKER_BUBBLE_VIEW_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/bubble/bubble_dialog_delegate.h"
 #include "ui/views/controls/button/button.h"
 
 namespace content {
 class NavigationHandle;
 class WebContents;
 }  // namespace content
 
 namespace views {
 class Label;
-class LabelButton;
 class View;
 class Widget;
 }  // namespace views
 
 namespace ui {
 class Event;
 }  // namespace ui
 
+class IntentPickerMenuButton;
+
 // A bubble that displays a list of aplications (icons and names), after the
 // list we show a pair of buttons which allow the user to remember the selection
 // or not. This class comunicates the user's selection with a callback used by
 // ArcNavigationThrottle.
 //   +--------------------------------+
 //   | Open with                      |
 //   |                                |
 //   | Icon1  Name1                   |
 //   | Icon2  Name2                   |
 //   |  ...                           |
@@ skipping 17 matching lines @@
 
   ~IntentPickerBubbleView() override;
   static void ShowBubble(content::NavigationHandle* handle,
                          const std::vector<NameAndIcon>& app_info,
                          const ThrottleCallback& throttle_cb);
   static std::unique_ptr<IntentPickerBubbleView> CreateBubbleView(
       const std::vector<NameAndIcon>& app_info,
       const ThrottleCallback& throttle_cb,
       content::WebContents* web_contents);
 
+  // views::DialogDelegate overrides:
+  bool Accept() override;
+  bool Cancel() override;
+  bool Close() override;
+  int GetDefaultDialogButton() const override;
+
  protected:
   // views::BubbleDialogDelegateView overrides:
   void Init() override;
 
+  // views::WidgetDelegate overrides:
+  base::string16 GetWindowTitle() const override;
+  base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
+
  private:
   friend class IntentPickerBubbleViewTest;
   FRIEND_TEST_ALL_PREFIXES(IntentPickerBubbleViewTest, NullIcons);
   FRIEND_TEST_ALL_PREFIXES(IntentPickerBubbleViewTest, NonNullIcons);
   FRIEND_TEST_ALL_PREFIXES(IntentPickerBubbleViewTest, LabelsPtrVectorSize);
   IntentPickerBubbleView(const std::vector<NameAndIcon>& app_info,
                          ThrottleCallback throttle_cb,
                          content::WebContents* web_contents);
 
   // views::BubbleDialogDelegateView overrides:
   void OnWidgetDestroying(views::Widget* widget) override;
   int GetDialogButtons() const override;
 
   // views::ButtonListener overrides:
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
   // views::View overrides:
   gfx::Size GetPreferredSize() const override;
 
   // content::WebContentsObserver overrides:
   void WebContentsDestroyed() override;
 
-  // Retrieves the LabelButton* contained at position |index| from the internal
-  // ScrollView.
-  views::LabelButton* GetLabelButtonAt(size_t index);
-  void SetLabelButtonBackgroundColor(size_t index, SkColor color);
+  // Retrieves the IntentPickerMenuButton* contained at position |index| from
+  // the internal ScrollView.
+  IntentPickerMenuButton* GetIntentPickerMenuButtonAt(size_t index);
+  void SetIntentPickerMenuButtonBackgroundColor(size_t index, SkColor color);
+  gfx::ImageSkia GetAppImageForTesting(size_t index);
 
   // Flag set to true iff the callback was Run at some previous step, used to
   // ensure we only use the callback once.
   bool was_callback_run_;
 
   // Callback used to respond to ArcNavigationThrottle.
   ThrottleCallback throttle_cb_;
 
   // Keeps a invalid value unless the user explicitly makes a decision.
   size_t selected_app_tag_;
 
-  views::LabelButton* always_button_;
-  views::LabelButton* just_once_button_;
   views::ScrollView* scroll_view_;
 
   std::vector<NameAndIcon> app_info_;
 
   DISALLOW_COPY_AND_ASSIGN(IntentPickerBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_INTENT_PICKER_BUBBLE_VIEW_H_