Issue 22299009: Move channel-related (Chrome-specific) global state out of Feature.

Issue 22299009: Move channel-related (Chrome-specific) global state out of Feature. (Closed)

Created:
7 years, 4 months ago by Yoyo Zhou

Modified:
7 years, 4 months ago

Reviewers:
kalman_google, Matt Perry, not at google - send to devlin

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move channel-related (Chrome-specific) global state out of Feature. BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216613

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -102 lines)			Patch
M	chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/app_window/app_window_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/extension_action/script_badge_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_system.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/script_badge_controller_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/features/base_feature_provider_unittest.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/features/complex_feature_unittest.cc	View	6 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/features/feature.h	View	2 chunks	+0 lines, -29 lines	0 comments	Download
M	chrome/common/extensions/features/feature.cc	View	2 chunks	+0 lines, -24 lines	0 comments	Download
A	chrome/common/extensions/features/feature_channel.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/features/feature_channel.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/features/simple_feature.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/features/simple_feature_unittest.cc	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifest_test.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/permissions/permissions_data_unittest.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/dispatcher.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/module_system.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/22299009/1

7 years, 4 months ago (2013-08-08 21:22:07 UTC) #3

not at google - send to devlin

What are you planning to do from there?

7 years, 4 months ago (2013-08-09 19:22:06 UTC) #5

Yoyo Zhou

Move Feature and Manifest to extensions/common. sent from a tiny touchscreen On Aug 9, 2013 ...

7 years, 4 months ago (2013-08-09 20:06:44 UTC) #6

kalman_google

Features still rely on chrome channels though. On 9 Aug 2013 13:06, "Yoyo Zhou" <yoz@chromium.org> ...

7 years, 4 months ago (2013-08-10 00:10:24 UTC) #7

Yoyo Zhou

7 years, 4 months ago (2013-08-12 18:42:57 UTC) #8

On Fri, Aug 9, 2013 at 5:10 PM, Benjamin Kalman <kalman@google.com> wrote:
> Features still rely on chrome channels though.

Our current implementation of features (e.g. SimpleFeature) does. But
some other content embedder could have a different features
implementation that doesn't know about channels.

Expand Messages | Collapse Messages