Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime

Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229893002

Committed: https://skia.googlesource.com/skia/+/80ac591f9928f36ea1dac80f34b9ad048e92ef73

[Harry Stern, 2016-08-09 17:49:41]

Description was changed from

==========
Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime

BUG=skia:
==========

to

==========
Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229893002
==========

[Harry Stern, 2016-08-09 17:55:18]

hstern@google.com changed reviewers:
+ caryclark@google.com, reed@google.com

[Harry Stern, 2016-08-09 17:55:18]

hstern@google.com changed reviewers:
+ caryclark@google.com, reed@google.com

[Harry Stern, 2016-08-09 17:55:18]

This somewhat breaks "compatibility" with SkPathMeasure but we never really had
compatibility because CurveMeasure only takes a curve, not an entire path
anyway.

[Harry Stern, 2016-08-09 17:55:18]

This somewhat breaks "compatibility" with SkPathMeasure but we never really had
compatibility because CurveMeasure only takes a curve, not an entire path
anyway.

[reed1, 2016-08-09 17:59:02]

seems fine to me, since you're measuring a new utility that has new/different
functionality.

lgtm

[reed1, 2016-08-09 17:59:35]

do we also have a unit-test or some other code that exercises the time
parameter?

[Harry Stern, 2016-08-09 20:51:18]

On 2016/08/09 17:59:35, reed1 wrote:
> do we also have a unit-test or some other code that exercises the time
> parameter?

Besides the bench there is no code that runs any code in SkCurveMeasure.cpp. I'd
like to have a test that compares it to SkPathMeasure for each curve type (and
probably a separate one for the forthcoming SkDashMeasure.h) which, eg for a
quadratic, fixes the two endpoints and moves the control through a large range
of points, and measures N equal-length pieces along the curve, and errors if
they differ by some tolerance.

[Harry Stern, 2016-08-09 20:51:25]

The CQ bit was checked by hstern@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 20:51:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 21:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 21:17:07]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-10 11:56:07]

Lets land a CL soon that does *some* exercising of the new API -- doesn't
necessarily need to be a full-blown comparison with PathMeasure (thought that
will be wanted eventually).

lgtm

[Harry Stern, 2016-08-10 14:44:27]

The CQ bit was checked by hstern@google.com

[commit-bot: I haz the power, 2016-08-10 14:44:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:45:34]

Description was changed from

==========
Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229893002
==========

to

==========
Add time return argument to SkCurveMeasure's getPosTan, rename to getPosTanTime

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229893002

Committed:
https://skia.googlesource.com/skia/+/80ac591f9928f36ea1dac80f34b9ad048e92ef73
==========

[commit-bot: I haz the power, 2016-08-10 14:45:35]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/80ac591f9928f36ea1dac80f34b9ad048e92ef73