Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2229853002: Sample app uses Ganesh before calling SkGraphics::Init(). (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sample app uses Ganesh before calling SkGraphics::Init(). This causes inconsistent hashing. Before Init(), we use portable Murmur3, after a faster SSE4.2-based hash. To fix, call SkGraphics::Init() first. BUG=skia:5625 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229853002 Committed: https://skia.googlesource.com/skia/+/2ee6982d952faa8fd2aa09dec787bb5157840445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M src/views/mac/skia_mac.mm View 3 chunks +15 lines, -13 lines 0 comments Download
M src/views/unix/skia_unix.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/views/win/skia_win.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 4 months ago (2016-08-09 16:35:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229853002/1
4 years, 4 months ago (2016-08-09 16:35:45 UTC) #7
f(malita)
lgtm
4 years, 4 months ago (2016-08-09 16:37:47 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 17:13:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ee6982d952faa8fd2aa09dec787bb5157840445

Powered by Google App Engine
This is Rietveld 408576698