Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2229833002: Revert of Move ChromeVox loading out of ComponentLoader. (Closed)

Created:
4 years, 4 months ago by David Tseng
Modified:
4 years, 4 months ago
Reviewers:
Devlin, dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, David Tseng, extensions-reviews_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ChromeVox loading out of ComponentLoader. (patchset #3 id:40001 of https://codereview.chromium.org/2212853002/ ) Reason for revert: BUG=635294 Repro: - run Chrome OS on linux with an existing profile and with the flag --login-manager - sign in or go through OOBE with ChromeVox on (and working) result: content scripts appear to be broken when logged in. I suspect user ChromeVox isn't loading. Original issue's description: > Move ChromeVox loading out of ComponentLoader. > > First, it isn't actually necessary to load ChromeVox from > ComponentLoader. This code is probably historical. For quite some time, > AccessibilityManager automatically loads ChromeVox on startup if the > flag is set (and automatically loads/unloads when the flag changes). > We should load it from only one place. Tested manually during startup > and when logging into a session, both work fine without this call. > > Second, I intend to refactor AccessibilityManager so that it can support > multiple accessibility component extensions. Rather than a separate function > in ComponentLoader to load each one, I think it'd make more sense for > AccessibilityManager to just call ComponentLoader with the appropriate > parameters like the extension id and path. > > BUG=634233 > > Committed: https://crrev.com/18f89cf0b120afff95e064f437140bdbfb33ef36 > Cr-Commit-Position: refs/heads/master@{#409916} TBR=rdevlin.cronin@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=634233 Committed: https://crrev.com/03bc1f9c36c253bfd2ef0b53cf621a52128198f3 Cr-Commit-Position: refs/heads/master@{#410685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -21 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 2 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 4 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
David Tseng
Created Revert of Move ChromeVox loading out of ComponentLoader.
4 years, 4 months ago (2016-08-09 15:02:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229833002/1
4 years, 4 months ago (2016-08-09 15:02:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 15:50:23 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:52:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03bc1f9c36c253bfd2ef0b53cf621a52128198f3
Cr-Commit-Position: refs/heads/master@{#410685}

Powered by Google App Engine
This is Rietveld 408576698