Chromium Code Reviews
DescriptionRevert of Move ChromeVox loading out of ComponentLoader. (patchset #3 id:40001 of https://codereview.chromium.org/2212853002/ )
Reason for revert:
BUG=635294
Repro:
- run Chrome OS on linux with an existing profile and with the flag --login-manager
- sign in or go through OOBE with ChromeVox on (and working)
result:
content scripts appear to be broken when logged in. I suspect user ChromeVox isn't loading.
Original issue's description:
> Move ChromeVox loading out of ComponentLoader.
>
> First, it isn't actually necessary to load ChromeVox from
> ComponentLoader. This code is probably historical. For quite some time,
> AccessibilityManager automatically loads ChromeVox on startup if the
> flag is set (and automatically loads/unloads when the flag changes).
> We should load it from only one place. Tested manually during startup
> and when logging into a session, both work fine without this call.
>
> Second, I intend to refactor AccessibilityManager so that it can support
> multiple accessibility component extensions. Rather than a separate function
> in ComponentLoader to load each one, I think it'd make more sense for
> AccessibilityManager to just call ComponentLoader with the appropriate
> parameters like the extension id and path.
>
> BUG=634233
>
> Committed: https://crrev.com/18f89cf0b120afff95e064f437140bdbfb33ef36
> Cr-Commit-Position: refs/heads/master@{#409916}
TBR=rdevlin.cronin@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=634233
Committed: https://crrev.com/03bc1f9c36c253bfd2ef0b53cf621a52128198f3
Cr-Commit-Position: refs/heads/master@{#410685}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||