Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/frame/FrameViewTest.cpp

Issue 2229753002: Test that FrameView::incrementVisuallyNonEmptyPixelCount() doesn't overflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add SimTest Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameViewTest.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
index 5438ffa3f6faa0fd4d4b988dacfb5034e893a72a..9cb516b93f47261f07c1969bf5ec4c2dc44654fa 100644
--- a/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
@@ -167,5 +167,15 @@ TEST_P(FrameViewTest, HideTooltipWhenScrollPositionChanges)
document().view()->layoutViewportScrollableArea()->setScrollPosition(DoublePoint(1, 1), UserScroll);
}
+// NoOverflowInIncrementVisuallyNonEmptyPixelCount tests fail if the number of
+// pixels is calculated in 32-bit integer, because 65536 * 65536 would become 0
+// if it was calculated in 32-bit and thus it would be considered as empty.
+TEST_P(FrameViewTest, NoOverflowInIncrementVisuallyNonEmptyPixelCount)
+{
+ EXPECT_FALSE(document().view()->isVisuallyNonEmpty());
+ document().view()->incrementVisuallyNonEmptyPixelCount(IntSize(65536, 65536));
+ EXPECT_TRUE(document().view()->isVisuallyNonEmpty());
+}
+
} // namespace
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698