third_party/WebKit/Source/core/html/HTMLCanvasElement.h - Issue 2229743003: add HitTestCanvasResult Class instend of std::pair<Element*, String>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

Issue 2229743003: add HitTestCanvasResult Class instend of std::pair<Element*, String> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('j') | third_party/WebKit/Source/core/layout/HitTestResult.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

index d6f413b18f3fc9de81c825da7bc780f84329d7b6..a36a95aff7563c69c284bc13d98b7a9f99fa71e7 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

@@ -57,6 +57,7 @@ class CanvasContextCreationAttributes;

class CanvasRenderingContext;

class CanvasRenderingContextFactory;

class GraphicsContext;

+class HitTestCanvasResult;

class HTMLCanvasElement;

class Image;

class ImageBitmapOptions;

@@ -200,7 +201,7 @@ public:

// For Canvas HitRegions

bool isSupportedInteractiveCanvasFallback(const Element&);

- std::pair<Element*, String> getControlAndIdIfHitRegionExists(const LayoutPoint&);

+ HitTestCanvasResult* getControlAndIdIfHitRegionExists(const LayoutPoint&);

String getIdFromControl(const Element*);

// For OffscreenCanvas that controls this html canvas element