content/shell/renderer/test_runner/WebPermissions.h - Issue 222973003: Conversion of content_shell target to use WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/WebPermissions.h

Issue 222973003: Conversion of content_shell target to use WebLocalFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove some TODOs Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/test_runner/WebPermissions.h

diff --git a/content/shell/renderer/test_runner/WebPermissions.h b/content/shell/renderer/test_runner/WebPermissions.h

index 724dc58982f241b0108fba834de768eb975aa580..2ccc8eb552cb5b6226d3b08d80302e165477f6f1 100644

--- a/content/shell/renderer/test_runner/WebPermissions.h

+++ b/content/shell/renderer/test_runner/WebPermissions.h

@@ -19,12 +19,22 @@ public:

// Override WebPermissionClient methods.

// TODO(jam): remove all these methods after Blink rolls.

- virtual bool allowImage(blink::WebFrame*, bool enabledPerSettings, const blink::WebURL& imageURL);

- virtual bool allowScriptFromSource(blink::WebFrame*, bool enabledPerSettings, const blink::WebURL& scriptURL);

- virtual bool allowStorage(blink::WebFrame*, bool local);

- virtual bool allowPlugins(blink::WebFrame*, bool enabledPerSettings);

- virtual bool allowDisplayingInsecureContent(blink::WebFrame*, bool enabledPerSettings, const blink::WebSecurityOrigin&, const blink::WebURL&);

- virtual bool allowRunningInsecureContent(blink::WebFrame*, bool enabledPerSettings, const blink::WebSecurityOrigin&, const blink::WebURL&);

+ virtual bool allowImage(blink::WebLocalFrame*,

+ bool enabledPerSettings,

+ const blink::WebURL& imageURL);

+ virtual bool allowScriptFromSource(blink::WebLocalFrame*,

+ bool enabledPerSettings,

+ const blink::WebURL& scriptURL);

+ virtual bool allowStorage(blink::WebLocalFrame*, bool local);

+ virtual bool allowPlugins(blink::WebLocalFrame*, bool enabledPerSettings);

+ virtual bool allowDisplayingInsecureContent(blink::WebLocalFrame*,

+ bool enabledPerSettings,

+ const blink::WebSecurityOrigin&,

+ const blink::WebURL&);

+ virtual bool allowRunningInsecureContent(blink::WebLocalFrame*,

+ bool enabledPerSettings,

+ const blink::WebSecurityOrigin&,

+ const blink::WebURL&);

virtual bool allowImage(bool enabledPerSettings, const blink::WebURL& imageURL);

virtual bool allowScriptFromSource(bool enabledPerSettings, const blink::WebURL& scriptURL);