Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: content/public/renderer/render_frame.h

Issue 222973003: Conversion of content_shell target to use WebLocalFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove some TODOs Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/render_frame.h
diff --git a/content/public/renderer/render_frame.h b/content/public/renderer/render_frame.h
index f7de4467c1f6ecf18f79ae98baadf3ac6db67aec..19feb7d557faf6a50f97a06612bd583d1c7949c1 100644
--- a/content/public/renderer/render_frame.h
+++ b/content/public/renderer/render_frame.h
@@ -9,6 +9,8 @@
#include "content/common/content_export.h"
#include "ipc/ipc_listener.h"
#include "ipc/ipc_sender.h"
+// TODO(dcheng): Convert back to a forward declare.
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
Charlie Reis 2014/04/02 23:34:15 Why is this needed for now? And what will change
dcheng 2014/04/02 23:47:08 WebLocalFrame is currently a typedef, and you cann
Charlie Reis 2014/04/03 00:37:11 I see, thanks.
#include "third_party/WebKit/public/web/WebNavigationPolicy.h"
struct WebPreferences;
@@ -77,10 +79,9 @@ class CONTENT_EXPORT RenderFrame : public IPC::Listener,
const blink::WebPluginParams& params) = 0;
// The client should handle the navigation externally.
- virtual void LoadURLExternally(
- blink::WebFrame* frame,
- const blink::WebURLRequest& request,
- blink::WebNavigationPolicy policy) = 0;
+ virtual void LoadURLExternally(blink::WebLocalFrame* frame,
+ const blink::WebURLRequest& request,
+ blink::WebNavigationPolicy policy) = 0;
// Execute a string of JavaScript in this frame's context.
virtual void ExecuteJavaScript(const base::string16& javascript) = 0;
« no previous file with comments | « no previous file | content/public/renderer/render_view.h » ('j') | content/public/renderer/render_view_observer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698