Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 222973002: Remove prompt for default project ID (Closed)

Created:
6 years, 8 months ago by hinoka
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove prompt for default project ID The "What is your project ID" has confused about every user of gsutil that I've talked to, and isn't even useful in the context of download_from_google_storage because its only good for "mb" on a bucket and "ls" without specifying a bucket, neither of which this version of gsutil should ever do. This CL: * Removes the prompt for project ID * Removes the 2 second delay which was meant for autolaunching a browser * We don't want this behavior anyways because most of our devs have multiple browser profiles open and they need to paste the URL into the correct profile. * Removes support to autolaunch a broswer. * Removes a lot of the extra messages. The prompt now looks like: === $ download_from_google_storage -g Please navigate your browser to the following URL: https://accounts.google.com/o/oauth2/auth?..... Enter the authorization code: <code> Boto config file "/usr/local/google/home/hinoka/.boto.depot_tools" created. $ === BUG=351015 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=267973

Patch Set 1 #

Patch Set 2 : Drastically reduced the number of messages #

Total comments: 7

Patch Set 3 : Review fix #

Patch Set 4 : Revert spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -42 lines) Patch
M third_party/gsutil/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/gsutil/gslib/commands/config.py View 1 2 3 3 chunks +2 lines, -34 lines 0 comments Download
M third_party/gsutil/oauth2_plugin/oauth2_helper.py View 1 2 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hinoka
+scottmg reviewer since he's complained about this before +maruel approval
6 years, 8 months ago (2014-04-02 21:14:08 UTC) #1
scottmg
Awesome, thanks. lgtm.
6 years, 8 months ago (2014-04-02 21:25:31 UTC) #2
M-A Ruel
https://codereview.chromium.org/222973002/diff/10004/third_party/gsutil/gslib/commands/config.py File third_party/gsutil/gslib/commands/config.py (left): https://codereview.chromium.org/222973002/diff/10004/third_party/gsutil/gslib/commands/config.py#oldcode576 third_party/gsutil/gslib/commands/config.py:576: if default_project_id: this change is not necessary. https://codereview.chromium.org/222973002/diff/10004/third_party/gsutil/gslib/commands/config.py#oldcode626 third_party/gsutil/gslib/commands/config.py:626: ...
6 years, 8 months ago (2014-04-02 21:29:43 UTC) #3
Ryan Tseng
https://codereview.chromium.org/222973002/diff/10004/third_party/gsutil/gslib/commands/config.py File third_party/gsutil/gslib/commands/config.py (left): https://codereview.chromium.org/222973002/diff/10004/third_party/gsutil/gslib/commands/config.py#oldcode576 third_party/gsutil/gslib/commands/config.py:576: if default_project_id: On 2014/04/02 21:29:43, M-A Ruel wrote: > ...
6 years, 8 months ago (2014-04-02 22:07:03 UTC) #4
iannucci
lgtm
6 years, 7 months ago (2014-05-02 23:28:01 UTC) #5
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 7 months ago (2014-05-02 23:39:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/222973002/50001
6 years, 7 months ago (2014-05-02 23:39:48 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 23:42:45 UTC) #8
Message was sent while issue was closed.
Change committed as 267973

Powered by Google App Engine
This is Rietveld 408576698