Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: src/runtime/runtime-compiler.cc

Issue 2229723002: [wasm] Support validation of asm.js modules with != 3 args. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: file change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-compiler.cc
diff --git a/src/runtime/runtime-compiler.cc b/src/runtime/runtime-compiler.cc
index 862fefcd5045ad3fbc7a5dcd85c2b032be34387a..5fb28c61ff4a0c50473e8a7af064a987d47cfa01 100644
--- a/src/runtime/runtime-compiler.cc
+++ b/src/runtime/runtime-compiler.cc
@@ -101,8 +101,9 @@ RUNTIME_FUNCTION(Runtime_InstantiateAsmJs) {
return *result.ToHandleChecked();
}
}
- // Remove wasm data and return a smi 0 to indicate failure.
- function->shared()->ClearAsmWasmData();
+ // Return a smi 0 to indicate failure.
+ // AsmWasmData will get removed later as a consequence (but is kept so we
Michael Starzinger 2016/08/11 11:44:10 See comments in compiler.cc about this.
bradn 2016/08/12 01:17:09 Done.
+ // know we've tried this and failed).
return Smi::FromInt(0);
}

Powered by Google App Engine
This is Rietveld 408576698