third_party/WebKit/LayoutTests/editing/pasteboard/cut-paste-formatting-tag.html - Issue 2229703004: Keep formatting tags included when it is cut or copied.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/pasteboard/cut-paste-formatting-tag.html

Issue 2229703004: Keep formatting tags included when it is cut or copied. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test fails Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype HTML>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../assert_selection.js"></script>

	5 <script>

	6

	7 test(() => assert_selection(

	8 '<div contenteditable id="editor" style="width: 300px; height: 250px; border: 1px solid black"><div><b>^<br></b></div><b>foo\|</b></div>',

	9 selection => {

	10 var editor = selection.document.getElementById('editor');
	yosin_UTC9 2016/08/12 01:37:34 nit: Could you get rid of \|var editor = ...\| since nit: Could you get rid of \|var editor = ...\| since this script doesn't use \|editor\|? joone 2016/08/12 22:12:21 Done. Show quoted text On 2016/08/12 01:37:34, Yosi_UTC9 wrote: > nit: Could you get rid of \|var editor = ...\| since this script doesn't use > \|editor\|? Done.
	11

	12 selection.document.execCommand('cut');

	13 selection.document.execCommand('paste');

	14 },

	15 '<div contenteditable id="editor" style="width: 300px; height: 250px; border: 1px solid black"><br><div><b>foo\|</b></div></div>'),
	joone 2016/08/10 21:31:31 The layout test result is a bit different from run The layout test result is a bit different from running https://bugs.chromium.org/p/chromium/issues/attachmentText?aid=245594 in Chromium browser: This is the result of Chrome browser without this fix: <div contenteditable="true" id="ce" style="width: 300px; height: 250px; border: 1px solid black"> <br class="Apple-interchange-newline"> <span style="font-weight: bold;">aaaa</span> <br> </div> This is the layout test result without this fix: <div contenteditable id="editor" style="width: 300px; height: 250px; border: 1px solid black"> <br> <div> <span style="font-weight: bold;">foo\|</span> </div> </div> This is the result of Chrome browser with this fix: <div contenteditable="true" id="ce" style="width: 300px; height: 250px; border: 1px solid black"> <b><br class="Apple-interchange-newline">aaaa</b> <br> </div> This is the layout test result with this fix: <div contenteditable id="editor" style="width: 300px; height: 250px; border: 1px solid black"> <br> <div> <b>foo\|</b> </div> </div>
	16 'Cut all tags and paste them');

	17

	18 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingUtilities.h » ('j') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('J')