Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2229703002: Improve canBeAnchorNode() for PositionInFlatTree constructor (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve canBeAnchorNode() for PositionInFlatTree constructor This patch changes |canBeAnchorNode()| for |PositionInFlatTree| constructor to check whether specified node can be participate to flat tree or not to improve debug experience. This patch is a preparation of http://crrev.com/2221783003, which attempt to call |toPositionInFlatTree()| with a position which uses |ShadowRoot| as anchor node. BUG=139552, 632333 TEST=n/a; no behavior changes Committed: https://crrev.com/d0bf55edc59dd1399c5892f1afb2643ea978bddb Cr-Commit-Position: refs/heads/master@{#410629}

Patch Set 1 : 2016-08-09T13:48:05 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/Position.cpp View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-09 07:19:43 UTC) #7
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-09 09:12:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229703002/1
4 years, 4 months ago (2016-08-09 09:31:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 10:54:28 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 10:55:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0bf55edc59dd1399c5892f1afb2643ea978bddb
Cr-Commit-Position: refs/heads/master@{#410629}

Powered by Google App Engine
This is Rietveld 408576698