Issue 22297007: Add config option to skimage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22297007: Add config option to skimage. (Closed)

Created:
7 years, 4 months ago by scroggo

Modified:
7 years, 4 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Add config option to skimage. Allows testing 565 and A8, in addition to 8888. Also makes the preference consistent for each test (in one run). BUG=skia:1465 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10579

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	tools/skimage_main.cpp	View		6 chunks	+21 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

djsollen

lgtm. will this change the bot output since they don't explicitly specify 8888?

7 years, 4 months ago (2013-08-06 18:41:08 UTC) #2

scroggo

On 2013/08/06 18:41:08, djsollen wrote: > lgtm. will this change the bot output since they ...

7 years, 4 months ago (2013-08-06 18:49:20 UTC) #3

scroggo

7 years, 4 months ago (2013-08-06 18:56:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r10579 (presubmit successful).