Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2229693002: ServiceWorker: Re-enable FetchEvent_respondWithRejection (Closed)

Created:
4 years, 4 months ago by shimazu
Modified:
4 years, 4 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Re-enable FetchEvent_respondWithRejection Memory sanitizer shows an error of uninitialized read in service_worker_browsertest.cc. This patch adds a check if WaitForConsoleMessages has been already called, so the variable will be read only after WaitForConsoleMessages initializes it. BUG=635599 TEST=./out/msan/content_browsertests --no-sandbox --gtest_filter="ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection" Committed: https://crrev.com/4d4c3711a48ca7006ecf7e0a860994eaa8fd006e Cr-Commit-Position: refs/heads/master@{#410584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shimazu
ptal:)
4 years, 4 months ago (2016-08-09 03:16:46 UTC) #3
nhiroki
lgtm
4 years, 4 months ago (2016-08-09 04:08:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229693002/1
4 years, 4 months ago (2016-08-09 04:15:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 05:26:31 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 05:28:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d4c3711a48ca7006ecf7e0a860994eaa8fd006e
Cr-Commit-Position: refs/heads/master@{#410584}

Powered by Google App Engine
This is Rietveld 408576698