Fixing the broken CRD Windows MSI

Fixing the broken CRD Windows MSI

Just after the GN switch over I found that our official MSIs no longer
contained working binaries.  The MSI was also larger (by ~9MB) and I did not
see an icon in the add/remove programs applet for the CRD service.

All of these problems were caused by a single line in the host GN build file.
When the Windows installation target is built, there is a set of input files
and a set of destinations (for those files) which are fed into a python script.

The lines for chromoting.ico and icudtl.dat were swapped.  This means the MSI
was using icudtl.dat as the icon and chromoting.ico as the icu data file.

In order to try and prevent this issue from occuring again (which is really
easy miss in CR), I've added some organization and comments to the files list.

One note: this issue seems to only repro on release builds though I see the
incorrect files in the generated folders for my local builds without my change.
My assumption is that since I know the MSI is generated correctly (icon shows
up and package size is right) that the official build will also work.

BUG=634380
Committed: https://crrev.com/348cecd2dbd8cdcbba968c25e54857d209e756ac
Cr-Commit-Position: refs/heads/master@{#410719}

[joedow, 2016-08-09 02:05:51]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 02:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-08-09 03:04:15]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org, zijiehe@chromium.org

[joedow, 2016-08-09 03:04:15]

joedow@chromium.org changed required reviewers:
+ sergeyu@chromium.org

[joedow, 2016-08-09 03:04:15]

This is the fix for our GN Windows MSI.  PTAL!

Thanks,
Joe

[commit-bot: I haz the power, 2016-08-09 04:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 04:04:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sergey Ulanov, 2016-08-09 15:50:03]

s/our data file/icu data file/ in the CL description
otherwise LGTM

[joedow, 2016-08-09 16:16:44]

Description was changed from

==========
Fixing the broken CRD Windows MSI

Just after the GN switch over I found that our official MSIs no longer
contained working binaries.  The MSI was also larger (by ~9MB) and I did not
see an icon in the add/remove programs applet for the CRD service.

All of these problems were caused by a single line in the host GN build file.
When the Windows installation target is built, there is a set of input files
and a set of destinations (for those files) which are fed into a python script.

The lines for chromoting.ico and icudtl.dat were swapped.  This means the MSI
was using icudtl.dat as the icon and chromoting.ico as our data file.

In order to try and prevent this issue from occuring again (which is really
easy miss in CR), I've added some organization and comments to the files list.

One note: this issue seems to only repro on release builds though I see the
incorrect files in the generated folders for my local builds without my change.
My assumption is that since I know the MSI is generated correctly (icon shows
up and package size is right) that the official build will also work.

BUG=634380
==========

to

==========
Fixing the broken CRD Windows MSI

Just after the GN switch over I found that our official MSIs no longer
contained working binaries.  The MSI was also larger (by ~9MB) and I did not
see an icon in the add/remove programs applet for the CRD service.

All of these problems were caused by a single line in the host GN build file.
When the Windows installation target is built, there is a set of input files
and a set of destinations (for those files) which are fed into a python script.

The lines for chromoting.ico and icudtl.dat were swapped.  This means the MSI
was using icudtl.dat as the icon and chromoting.ico as the icu data file.

In order to try and prevent this issue from occuring again (which is really
easy miss in CR), I've added some organization and comments to the files list.

One note: this issue seems to only repro on release builds though I see the
incorrect files in the generated folders for my local builds without my change.
My assumption is that since I know the MSI is generated correctly (icon shows
up and package size is right) that the official build will also work.

BUG=634380
==========

[joedow, 2016-08-09 16:16:56]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 17:16:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 17:18:01]

Description was changed from

==========
Fixing the broken CRD Windows MSI

Just after the GN switch over I found that our official MSIs no longer
contained working binaries.  The MSI was also larger (by ~9MB) and I did not
see an icon in the add/remove programs applet for the CRD service.

All of these problems were caused by a single line in the host GN build file.
When the Windows installation target is built, there is a set of input files
and a set of destinations (for those files) which are fed into a python script.

The lines for chromoting.ico and icudtl.dat were swapped.  This means the MSI
was using icudtl.dat as the icon and chromoting.ico as the icu data file.

In order to try and prevent this issue from occuring again (which is really
easy miss in CR), I've added some organization and comments to the files list.

One note: this issue seems to only repro on release builds though I see the
incorrect files in the generated folders for my local builds without my change.
My assumption is that since I know the MSI is generated correctly (icon shows
up and package size is right) that the official build will also work.

BUG=634380
==========

to

==========
Fixing the broken CRD Windows MSI

Just after the GN switch over I found that our official MSIs no longer
contained working binaries.  The MSI was also larger (by ~9MB) and I did not
see an icon in the add/remove programs applet for the CRD service.

All of these problems were caused by a single line in the host GN build file.
When the Windows installation target is built, there is a set of input files
and a set of destinations (for those files) which are fed into a python script.

The lines for chromoting.ico and icudtl.dat were swapped.  This means the MSI
was using icudtl.dat as the icon and chromoting.ico as the icu data file.

In order to try and prevent this issue from occuring again (which is really
easy miss in CR), I've added some organization and comments to the files list.

One note: this issue seems to only repro on release builds though I see the
incorrect files in the generated folders for my local builds without my change.
My assumption is that since I know the MSI is generated correctly (icon shows
up and package size is right) that the official build will also work.

BUG=634380

Committed: https://crrev.com/348cecd2dbd8cdcbba968c25e54857d209e756ac
Cr-Commit-Position: refs/heads/master@{#410719}
==========

[commit-bot: I haz the power, 2016-08-09 17:18:01]

Patchset 1 (id:??) landed as
https://crrev.com/348cecd2dbd8cdcbba968c25e54857d209e756ac
Cr-Commit-Position: refs/heads/master@{#410719}