Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2229663005: Add inlineOverflow and blockOverflow methods to NGFragment. (Closed)

Created:
4 years, 4 months ago by Gleb Lanbin
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger, ikilpatrick, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add inlineOverflow and blockOverflow methods to NGFragment and make it garbage-collected. BUG=635619 NOTRY=true Committed: https://crrev.com/d20368eb97bb4afc23803753ae8857c67a3b7f0b Cr-Commit-Position: refs/heads/master@{#410774}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/ng/NGFragment.h View 1 1 chunk +19 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/NGFragment.cpp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
Gleb Lanbin
4 years, 4 months ago (2016-08-09 16:15:09 UTC) #3
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-09 16:23:29 UTC) #5
eae
LGTM w/nit https://codereview.chromium.org/2229663005/diff/1/third_party/WebKit/Source/core/layout/ng/NGFragment.h File third_party/WebKit/Source/core/layout/ng/NGFragment.h (right): https://codereview.chromium.org/2229663005/diff/1/third_party/WebKit/Source/core/layout/ng/NGFragment.h#newcode24 third_party/WebKit/Source/core/layout/ng/NGFragment.h:24: // Returns the size of the contents ...
4 years, 4 months ago (2016-08-09 16:26:02 UTC) #6
Gleb Lanbin
https://codereview.chromium.org/2229663005/diff/1/third_party/WebKit/Source/core/layout/ng/NGFragment.h File third_party/WebKit/Source/core/layout/ng/NGFragment.h (right): https://codereview.chromium.org/2229663005/diff/1/third_party/WebKit/Source/core/layout/ng/NGFragment.h#newcode24 third_party/WebKit/Source/core/layout/ng/NGFragment.h:24: // Returns the size of the contents which are ...
4 years, 4 months ago (2016-08-09 16:37:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229663005/20001
4 years, 4 months ago (2016-08-09 16:38:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229663005/20001
4 years, 4 months ago (2016-08-09 19:16:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 19:49:13 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:50:54 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d20368eb97bb4afc23803753ae8857c67a3b7f0b
Cr-Commit-Position: refs/heads/master@{#410774}

Powered by Google App Engine
This is Rietveld 408576698