Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 222963003: ash: Small fixes for ash_unittests when building in aura. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Small fixes for ash_unittests when building in aura. Two function were hidden under chromeos ifdef, since they are called only on ChromeOS and one constant were also hidden under chromeos ifdef for the same reason. BUG=None TEST=./build/gyp_chromium -Duse_aura, ninja -C out/Debug ash_unittests R=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/lock_state_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 8 months ago (2014-04-03 02:35:35 UTC) #1
James Cook
LGTM, but I'm unclear why we need this. Is it so we can build ash_unittests ...
6 years, 8 months ago (2014-04-03 16:04:41 UTC) #2
tfarina
On 2014/04/03 16:04:41, James Cook wrote: > LGTM, but I'm unclear why we need this. ...
6 years, 8 months ago (2014-04-03 16:12:25 UTC) #3
James Cook
On 2014/04/03 16:12:25, tfarina wrote: > On 2014/04/03 16:04:41, James Cook wrote: > > LGTM, ...
6 years, 8 months ago (2014-04-03 16:20:23 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-03 16:23:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/222963003/1
6 years, 8 months ago (2014-04-03 16:23:51 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 18:11:05 UTC) #7
Message was sent while issue was closed.
Change committed as 261476

Powered by Google App Engine
This is Rietveld 408576698