Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2229603003: Extract unresolved AST parsing (PARSED_UNIT1) from full parsing, which includes UriBasedDirective(s… (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract unresolved AST parsing (PARSED_UNIT1) from full parsing, which includes UriBasedDirective(s) resolution. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6ad38498c8673f1fbe3e12c49b1cf590305676dd

Patch Set 1 #

Patch Set 2 : Update task graph. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -260 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/doc/tasks.html View 1 4 chunks +14 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 5 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 10 chunks +197 lines, -105 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 5 chunks +41 lines, -38 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 8 chunks +193 lines, -87 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 6 chunks +8 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 1 4 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-08 21:32:57 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-08 21:40:55 UTC) #2
scheglov
4 years, 4 months ago (2016-08-08 21:45:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6ad38498c8673f1fbe3e12c49b1cf590305676dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698