Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2229583003: [serializer] reserve maps one by one to avoid fragmentation. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] reserve maps one by one to avoid fragmentation. R=hpayer@chromium.org BUG=chromium:612816, chromium:634900 Committed: https://crrev.com/ead3188129df600f17e35ba197b2634218c637e8 Cr-Commit-Position: refs/heads/master@{#38515}

Patch Set 1 #

Patch Set 2 : Add some more checks. #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -17 lines) Patch
M src/address-map.h View 2 chunks +11 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +25 lines, -3 lines 0 comments Download
M src/snapshot/deserializer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 2 4 chunks +16 lines, -2 lines 0 comments Download
M src/snapshot/serializer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/snapshot/serializer.cc View 5 chunks +24 lines, -8 lines 0 comments Download
M src/snapshot/serializer-common.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Yang
4 years, 4 months ago (2016-08-09 13:09:57 UTC) #1
Hannes Payer (out of office)
Awesome! LGTM Please add chromium:612816 and chromium:634900 to the BUG
4 years, 4 months ago (2016-08-09 13:55:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229583003/20001
4 years, 4 months ago (2016-08-10 05:35:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/22330)
4 years, 4 months ago (2016-08-10 05:41:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229583003/40001
4 years, 4 months ago (2016-08-10 05:50:49 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 06:31:18 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:31:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ead3188129df600f17e35ba197b2634218c637e8
Cr-Commit-Position: refs/heads/master@{#38515}

Powered by Google App Engine
This is Rietveld 408576698