Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2229583002: [LayoutNG] Add NGFragment class definition. (Closed)

Created:
4 years, 4 months ago by ikilpatrick
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add NGFragment class definition. Define initial fragment placeholder. Initially just contains the inline/block size, and inline/block offset. BUG=591099 Committed: https://crrev.com/585b50077748e8a19221d736e307a3cf0c18e0e2 Cr-Commit-Position: refs/heads/master@{#410446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/NGFragment.h View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/NGFragment.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ikilpatrick
4 years, 4 months ago (2016-08-08 19:11:59 UTC) #4
cbiesinger
lgtm
4 years, 4 months ago (2016-08-08 19:13:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229583002/1
4 years, 4 months ago (2016-08-08 19:13:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:40:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:42:45 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/585b50077748e8a19221d736e307a3cf0c18e0e2
Cr-Commit-Position: refs/heads/master@{#410446}

Powered by Google App Engine
This is Rietveld 408576698