Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2229573002: Change the canonical way to include the C macros.h to <mojo/macros.h>. (Closed)

Created:
4 years, 4 months ago by viettrungluu
Modified:
4 years, 4 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change the canonical way to include the C macros.h to <mojo/macros.h>. I've updated includes everywhere except in headers under mojo/public/{c,cpp}. This is because doing so will require making sure that public_deps are used appropriately everywhere, and it'll be easier to do so as I'm moving other headers under mojo/public/c to the new scheme. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5d24787424f3c7ca77b1de906d6aec0a6ba8311c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -116 lines) Patch
M examples/c/echo_client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/c/echo_client/echo_client.c View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/platform/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/platform/scoped_platform_handle.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/connection_manager_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/core.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M mojo/edk/system/memory.h View 2 chunks +1 line, -1 line 0 comments Download
M mojo/edk/system/memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/options_validation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/util/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/util/string_printf.h View 1 chunk +1 line, -2 lines 0 comments Download
A mojo/public/c/BUILD.gn View 1 chunk +41 lines, -0 lines 0 comments Download
A + mojo/public/c/include/mojo/macros.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/c/system/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/c/system/macros.h View 1 chunk +6 lines, -80 lines 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/compile_unittest_pure_c.c View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/compile_unittest_pure_cpp.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/macros_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/message_pipe_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/perftest_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/wait_set_perftest.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_test_input_parser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/utility/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/utility/lib/run_loop.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/services/files/c/lib/directory_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/files/c/lib/file_fd_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gfx/images/cpp/image_pipe_consumer_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gfx/images/cpp/image_pipe_endpoint.h View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/services/gfx/images/cpp/image_pipe_producer_endpoint.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojom/generators/c/templates/header.tmpl.go View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 4 months ago (2016-08-08 18:09:41 UTC) #1
jamesr
lgtm
4 years, 4 months ago (2016-08-08 19:25:44 UTC) #2
viettrungluu
Committed patchset #1 (id:1) manually as 5d24787424f3c7ca77b1de906d6aec0a6ba8311c (presubmit successful).
4 years, 4 months ago (2016-08-08 19:27:47 UTC) #4
vardhan
4 years, 4 months ago (2016-08-08 20:20:51 UTC) #5
Message was sent while issue was closed.
On 2016/08/08 19:27:47, viettrungluu wrote:
> Committed patchset #1 (id:1) manually as
> 5d24787424f3c7ca77b1de906d6aec0a6ba8311c (presubmit successful).

maybe i should add a presubmit check for mojo.git, but when there are changes to
the C generator, you currently need to upload a new binary and check in the sha1
as well:

$ mojom/tools/build_generators.py --generators c --upload

Powered by Google App Engine
This is Rietveld 408576698