Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2229553005: Use log prints for simulation tracing and fix --disassemble-stubs. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use log prints for simulation tracing and fix --disassemble-stubs. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/a0df7275d66788e41ebf1d0a8a3f4d71f4cc531d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M runtime/vm/simulator_arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rmacnak
4 years, 4 months ago (2016-08-09 20:54:57 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-08-09 20:56:20 UTC) #5
Cutch
lgtm lgtm
4 years, 4 months ago (2016-08-09 20:56:20 UTC) #6
rmacnak
4 years, 4 months ago (2016-08-09 21:03:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0df7275d66788e41ebf1d0a8a3f4d71f4cc531d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698