Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: cc/ipc/quads.mojom

Issue 2229553004: cc: Implement UnionTraits for DrawQuads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup according to Yuzhu's suggestion Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/ipc/quads_struct_traits.h » ('j') | cc/ipc/quads_struct_traits.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/quads.mojom
diff --git a/cc/ipc/quads.mojom b/cc/ipc/quads.mojom
index 772525891325f0c5383b46c25f3a047483a19508..c4e15d135a6b9ed6d1d9de2ab793e01ba8938cf7 100644
--- a/cc/ipc/quads.mojom
+++ b/cc/ipc/quads.mojom
@@ -98,9 +98,7 @@ struct YUVVideoQuadState {
};
enum Material {
yzshen1 2016/08/09 18:29:53 Could we also remove this definition?
Fady Samuel 2016/08/09 18:42:50 Done.
- INVALID,
DEBUG_BORDER,
- PICTURE_CONTENT,
RENDER_PASS,
SOLID_COLOR,
STREAM_VIDEO_CONTENT,
@@ -110,9 +108,18 @@ enum Material {
YUV_VIDEO_CONTENT,
};
-struct DrawQuad {
- Material material;
+union DrawQuadState {
+ DebugBorderQuadState debug_border_quad_state;
+ RenderPassQuadState render_pass_quad_state;
+ SolidColorQuadState solid_color_quad_state;
+ SurfaceQuadState surface_quad_state;
+ TextureQuadState texture_quad_state;
+ TileQuadState tile_quad_state;
+ StreamVideoQuadState stream_video_quad_state;
+ YUVVideoQuadState yuv_video_quad_state;
+};
+struct DrawQuad {
// This rect, after applying the quad_transform(), gives the geometry that
// this quad should draw to. This rect lives in content space.
gfx.mojom.Rect rect;
@@ -133,13 +140,5 @@ struct DrawQuad {
// quads.
SharedQuadState? sqs;
- // Only one of the following will be set, depending on the material.
- DebugBorderQuadState? debug_border_quad_state;
- RenderPassQuadState? render_pass_quad_state;
- SolidColorQuadState? solid_color_quad_state;
- SurfaceQuadState? surface_quad_state;
- TextureQuadState? texture_quad_state;
- TileQuadState? tile_quad_state;
- StreamVideoQuadState? stream_video_quad_state;
- YUVVideoQuadState? yuv_video_quad_state;
+ DrawQuadState draw_quad_state;
};
« no previous file with comments | « no previous file | cc/ipc/quads_struct_traits.h » ('j') | cc/ipc/quads_struct_traits.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698