Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: net/tools/quic/quic_socket_utils.h

Issue 2229553003: Deprecate --quic_socket_walltimestamps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128998762
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_packet_reader.cc ('k') | net/tools/quic/quic_socket_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_socket_utils.h
diff --git a/net/tools/quic/quic_socket_utils.h b/net/tools/quic/quic_socket_utils.h
index deaa4c8f71fd7d0735b1f83d67af37a64c13a3b7..fd72697fa9c223025f1d323f309cce2457a53a04 100644
--- a/net/tools/quic/quic_socket_utils.h
+++ b/net/tools/quic/quic_socket_utils.h
@@ -49,13 +49,9 @@ class QuicSocketUtils {
// Fills in |address| if |hdr| contains IP_PKTINFO or IPV6_PKTINFO. Fills in
// |timestamp| if |hdr| contains |SO_TIMESTAMPING|. |address| and |timestamp|
// must not be null.
- // TODO(rjshade): Delete the |timestamp| argument when removing
- // FLAGS_quic_socket_timestamps_walltime
static void GetAddressAndTimestampFromMsghdr(struct msghdr* hdr,
IPAddress* address,
- QuicTime* timestamp,
- QuicWallTime* walltimestamp,
- bool latched_walltimestamps);
+ QuicWallTime* walltimestamp);
// If the msghdr contains an SO_RXQ_OVFL entry, this will set dropped_packets
// to the correct value and return true. Otherwise it will return false.
@@ -90,16 +86,12 @@ class QuicSocketUtils {
// received packet, assuming a packet was read and the platform supports
// packet receipt timestamping. If the platform does not support packet
// receipt timestamping, timestamp will not be changed.
- // TODO(rjshade): Delete the |timestamp| argument when removing
- // FLAGS_quic_socket_timestamps_walltime
static int ReadPacket(int fd,
char* buffer,
size_t buf_len,
QuicPacketCount* dropped_packets,
IPAddress* self_address,
- QuicTime* timestamp,
QuicWallTime* walltimestamp,
- bool latched_walltimestamps,
IPEndPoint* peer_address);
// Writes buf_len to the socket. If writing is successful, sets the result's
« no previous file with comments | « net/tools/quic/quic_packet_reader.cc ('k') | net/tools/quic/quic_socket_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698