Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2229543002: Fix UseCounter for SubframeBeforeUnloadFired. (Closed)

Created:
4 years, 4 months ago by bokan
Modified:
4 years, 4 months ago
Reviewers:
ojan
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UseCounter for SubframeBeforeUnloadFired. The condition used to check whether the window is a subframe or not was wrong. It was originally `executingWindow != executingWindow->top()` but got accidentally changed in https://codereview.chromium.org/22564003. This CL fixes that error. BUG=635029 Committed: https://crrev.com/7d7dac7ca90eb803aa238e09ee6a183338e216c8 Cr-Commit-Position: refs/heads/master@{#410604}

Patch Set 1 #

Patch Set 2 : Now with test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
bokan
4 years, 4 months ago (2016-08-08 17:19:19 UTC) #3
ojan
lgtm
4 years, 4 months ago (2016-08-09 07:08:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229543002/20001
4 years, 4 months ago (2016-08-09 07:09:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 07:13:16 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:15:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d7dac7ca90eb803aa238e09ee6a183338e216c8
Cr-Commit-Position: refs/heads/master@{#410604}

Powered by Google App Engine
This is Rietveld 408576698