Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2229523002: Don't include MicrotasksScope in ConstructorMode (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
cbruni, haraken, esprehn
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include MicrotasksScope in ConstructorMode All the outgoing calls that are wrapped by a ConstructorMode scope object already explicitly disallow microtasks by using a MicrotaskScope. BUG=chromium:630217 Committed: https://crrev.com/87c7b7f62e9a948d8f647fed2b651b55327aaa0e Cr-Commit-Position: refs/heads/master@{#410618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
cbruni
PTAL
4 years, 4 months ago (2016-08-08 15:37:03 UTC) #5
haraken
LGTM
4 years, 4 months ago (2016-08-09 00:00:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229523002/1
4 years, 4 months ago (2016-08-09 07:02:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 08:46:41 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 08:48:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87c7b7f62e9a948d8f647fed2b651b55327aaa0e
Cr-Commit-Position: refs/heads/master@{#410618}

Powered by Google App Engine
This is Rietveld 408576698