Style invalidation support for :first/last/only-child.

Style invalidation support for :first/last/only-child.

Got rid of SubtreeStyleChanges for those pseudo classes. Also fixed
issue 245914 by looking at next/previous element, not node, to figure
out if we are the first. The code in checkForSiblingStyleChanges could
be restructured quite a bit and made simpler now have changedElement
(changedNode => changeElement since the input is always an element).

BUG=245914
Committed: https://crrev.com/798b5cdff6f50fa0d19a198f5f6e3f57425fbf05
Cr-Commit-Position: refs/heads/master@{#410472}

[rune, 2016-08-08 15:18:00]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 15:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:40:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 16:40:07]

Dry run: This issue passed the CQ dry run.

[rune, 2016-08-08 19:52:37]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, timloh@chromium.org

[rune, 2016-08-08 19:52:38]

ptal

[esprehn, 2016-08-08 20:07:53]

I think you want to call ContainerNode::hasRestyleFlag instead? :)

lgtm

https://codereview.chromium.org/2229503002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ContainerNode.cpp (right):

https://codereview.chromium.org/2229503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ContainerNode.cpp:1229: if (!hasRareData() ||
!rareData()->hasRestyleFlag(ChildrenAffectedByStructuralRules))
hasRestyleFlag is a method on ContainerNode which checks hasRareData for you

[rune, 2016-08-08 20:21:57]

https://codereview.chromium.org/2229503002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ContainerNode.cpp (right):

https://codereview.chromium.org/2229503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ContainerNode.cpp:1229: if (!hasRareData() ||
!rareData()->hasRestyleFlag(ChildrenAffectedByStructuralRules))
On 2016/08/08 20:07:53, esprehn wrote:
> hasRestyleFlag is a method on ContainerNode which checks hasRareData for you

Yup. Done.

[rune, 2016-08-08 20:22:47]

The CQ bit was checked by rune@opera.com

[rune, 2016-08-08 20:22:48]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2229503002/#ps20001
(title: "Fixed review issue")

[commit-bot: I haz the power, 2016-08-08 20:23:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:04:47]

Committed patchset #2 (id:20001)

[rune, 2016-08-08 22:06:49]

Description was changed from

==========
Style invalidation support for :first/last/only-child.

Got rid of SubtreeStyleChanges for those pseudo classes. Also fixed
issue 245914 by looking at next/previous element, not node, to figure
out if we are the first. The code in checkForSiblingStyleChanges could
be restructured quite a bit and made simpler now have changedElement
(changedNode => changeElement since the input is always an element).

BUG=245914
==========

to

==========
Style invalidation support for :first/last/only-child.

Got rid of SubtreeStyleChanges for those pseudo classes. Also fixed
issue 245914 by looking at next/previous element, not node, to figure
out if we are the first. The code in checkForSiblingStyleChanges could
be restructured quite a bit and made simpler now have changedElement
(changedNode => changeElement since the input is always an element).

BUG=635479
==========

[commit-bot: I haz the power, 2016-08-08 22:08:21]

Description was changed from

==========
Style invalidation support for :first/last/only-child.

Got rid of SubtreeStyleChanges for those pseudo classes. Also fixed
issue 245914 by looking at next/previous element, not node, to figure
out if we are the first. The code in checkForSiblingStyleChanges could
be restructured quite a bit and made simpler now have changedElement
(changedNode => changeElement since the input is always an element).

BUG=635479
==========

to

==========
Style invalidation support for :first/last/only-child.

Got rid of SubtreeStyleChanges for those pseudo classes. Also fixed
issue 245914 by looking at next/previous element, not node, to figure
out if we are the first. The code in checkForSiblingStyleChanges could
be restructured quite a bit and made simpler now have changedElement
(changedNode => changeElement since the input is always an element).

BUG=245914

Committed: https://crrev.com/798b5cdff6f50fa0d19a198f5f6e3f57425fbf05
Cr-Commit-Position: refs/heads/master@{#410472}
==========

[commit-bot: I haz the power, 2016-08-08 22:08:23]

Patchset 2 (id:??) landed as
https://crrev.com/798b5cdff6f50fa0d19a198f5f6e3f57425fbf05
Cr-Commit-Position: refs/heads/master@{#410472}