Deprecate CpuProfileNode::GetSelfSamplesCount

Deprecate CpuProfileNode::GetSelfSamplesCount

This method is being replaced by GetHitCount.

BUG=267595
R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16312

[yurys, 2013-08-08 14:03:25]

This change depends on the following Blink CL:
https://codereview.chromium.org/22684004/

[Sven Panne, 2013-08-09 05:54:19]

LGTM with a nit.

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:30: #define V8_DISABLE_DEPRECATIONS 1
Actually I would prefer kicking the deprecated calls out of the test suite,
especially when basically the same functionality is still tested. There is a
small trade-off involved, but we did this already before, so let's keep v8
itself "deprecation clean".

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:1373:
CHECK_GE(programNode->GetSelfSamplesCount(), 3);
Remove this...

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:1379: CHECK_GE(idleNode->GetSelfSamplesCount(),
3);
... and this line.

[yurys, 2013-08-09 07:29:30]

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:30: #define V8_DISABLE_DEPRECATIONS 1
On 2013/08/09 05:54:19, Sven Panne wrote:
> Actually I would prefer kicking the deprecated calls out of the test suite,
> especially when basically the same functionality is still tested. There is a
> small trade-off involved, but we did this already before, so let's keep v8
> itself "deprecation clean".

Done. I agree that in this case the same functionality is already tested.
However, in one of the past CLs I was suggested to keep existing tests for the
deprecated methods until they were completely removed from the public API and
that makes sense to me.

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:1373:
CHECK_GE(programNode->GetSelfSamplesCount(), 3);
On 2013/08/09 05:54:19, Sven Panne wrote:
> Remove this...

Done.

https://codereview.chromium.org/22295009/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:1379: CHECK_GE(idleNode->GetSelfSamplesCount(),
3);
On 2013/08/09 05:54:19, Sven Panne wrote:
> ... and this line.

Done.

[yurys, 2013-08-26 08:10:19]

Committed patchset #2 manually as r16312.