tools/json_schema_compiler/cpp_bundle_generator.py - Issue 22295002: Base infrastructure for Networking Private API on Windows and Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cpp_bundle_generator.py

Issue 22295002: Base infrastructure for Networking Private API on Windows and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use scoped_ptr to pass Verify* args to WorkerPool. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cpp_bundle_generator.py

diff --git a/tools/json_schema_compiler/cpp_bundle_generator.py b/tools/json_schema_compiler/cpp_bundle_generator.py

index c713d555f72ab0205f268b139561bd6d36c3b37b..a5ac51c3f1482c13b055843daf3d74b065764cfc 100644

--- a/tools/json_schema_compiler/cpp_bundle_generator.py

+++ b/tools/json_schema_compiler/cpp_bundle_generator.py

@@ -79,9 +79,15 @@ class CppBundleGenerator(object):

for platform in model_object.platforms:

if platform == Platforms.CHROMEOS:

ifdefs.append('defined(OS_CHROMEOS)')

+ elif platform == Platforms.LINUX:

+ ifdefs.append('defined(OS_LINUX)')

+ elif platform == Platforms.MAC:

+ ifdefs.append('defined(OS_MACOSX)')

+ elif platform == Platforms.WIN:

+ ifdefs.append('defined(OS_WIN)')

else:

raise ValueError("Unsupported platform ifdef: %s" % platform.name)

- return ' and '.join(ifdefs)

+ return ' || '.join(ifdefs)

def _GenerateRegisterFunctions(self, namespace_name, function):

c = code.Code()