Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 22295002: Base infrastructure for Networking Private API on Windows and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed compilation error. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/networking_private/networking_private_process_client.cc ('K') | « chrome/browser/extensions/api/networking_private/networking_private_process_client.cc ('k') | chrome/chrome.gyp » ('j') | chrome/utility/wifi/wifi_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_apitest.cc
diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc
index d2b9284a38ea420fcfe3c8943e8be156a33cd3ea..d7f3e14ebd9af24e2bac1b1fb496242641113a87 100644
--- a/chrome/browser/extensions/extension_apitest.cc
+++ b/chrome/browser/extensions/extension_apitest.cc
@@ -273,10 +273,10 @@ bool ExtensionApiTest::RunExtensionSubtest(const char* extension_name,
int flags) {
DCHECK(!page_url.empty()) << "Argument page_url is required.";
// See http://crbug.com/177163 for details.
-#if defined(OS_WIN) && !defined(NDEBUG)
- LOG(WARNING) << "Workaround for 177163, prematurely returning";
- return true;
-#endif
+ //#if defined(OS_WIN) && !defined(NDEBUG)
+ // LOG(WARNING) << "Workaround for 177163, prematurely returning";
+ // return true;
+ //#endif
stevenjb 2013/08/13 23:39:04 Eliminate before committing.
mef 2013/08/21 17:25:34 Will do, I had to comment it out to get my tests t
mef 2013/09/11 20:55:08 Done.
return RunExtensionTestImpl(extension_name, page_url, NULL, flags);
}
« chrome/browser/extensions/api/networking_private/networking_private_process_client.cc ('K') | « chrome/browser/extensions/api/networking_private/networking_private_process_client.cc ('k') | chrome/chrome.gyp » ('j') | chrome/utility/wifi/wifi_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698