chrome/browser/extensions/extension_apitest.cc - Issue 22295002: Base infrastructure for Networking Private API on Windows and Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 22295002: Base infrastructure for Networking Private API on Windows and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix NetworkingPrivateProcessClient lifetime tracking. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_apitest.cc

diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc

index 8ab9145c4236eb2dd9ff01aab6b8f42ba7a165bc..f54ee6fee04a05c8529141936c9fcaf0e2d2f089 100644

--- a/chrome/browser/extensions/extension_apitest.cc

+++ b/chrome/browser/extensions/extension_apitest.cc

@@ -276,8 +276,8 @@ bool ExtensionApiTest::RunExtensionSubtest(const std::string& extension_name,

DCHECK(!page_url.empty()) << "Argument page_url is required.";

// See http://crbug.com/177163 for details.

#if defined(OS_WIN) && !defined(NDEBUG)

- LOG(WARNING) << "Workaround for 177163, prematurely returning";

- return true;

+// LOG(WARNING) << "Workaround for 177163, prematurely returning";

+// return true;

#endif

return RunExtensionTestImpl(extension_name, page_url, NULL, flags);

}