Base infrastructure for Networking Private API on Windows and Mac.

chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc

Index: chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9d08a6f70a6a975e8760edbdbbcbb90c8e8253d8
--- /dev/null
+++ b/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc
@@ -0,0 +1,82 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/networking_private/networking_private_event_router.h"
+
+#include "chrome/browser/extensions/api/networking_private/networking_private_api.h"
+#include "chrome/browser/extensions/api/networking_private/networking_private_process_client.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/api/networking_private.h"
+
+using extensions::EventRouter;
+using extensions::ExtensionSystem;
+namespace api = extensions::api::networking_private;

[stevenjb, 2013/09/25 19:09:15]

None of this should be necessary since we are now using the extensions
namespace.

[mef, 2013/10/08 21:46:26]

Done.

+
+namespace extensions {
+
+NetworkingPrivateEventRouter::NetworkingPrivateEventRouter(Profile* profile)
+    : profile_(profile), listening_(false) {
+  // Register with the event router so we know when renderers are listening to
+  // our events. We first check and see if there *is* an event router, because
+  // some unit tests try to create all profile services, but don't initialize
+  // the event router first.
+  EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router();
+  if (event_router) {
+    event_router->RegisterObserver(
+        this,
+        extensions::api::networking_private::OnNetworksChanged::kEventName);
+    event_router->RegisterObserver(
+        this,
+        extensions::api::networking_private::OnNetworkListChanged::kEventName);
+    StartOrStopListeningForNetworkChanges();

[stevenjb, 2013/09/25 19:09:15]

This looks the same as the ChromeOS specific implementation. Rather than making
NetworkingPrivateEventRouter a pure virtual, maybe it makes sense to have a base
implementation with OS specific derived implementations?

[mef, 2013/10/08 21:46:26]

It seems that common parts are trivial, but differences are significant, so I've
done 2 separate implementations.

+  }
+}
+
+NetworkingPrivateEventRouter::~NetworkingPrivateEventRouter() {
+  DCHECK(!listening_);
+}
+
+void NetworkingPrivateEventRouter::Shutdown() {
+  // Unregister with the event router. We first check and see if there *is* an
+  // event router, because some unit tests try to shutdown all profile services,
+  // but didn't initialize the event router first.
+  EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router();
+  if (event_router)
+    event_router->UnregisterObserver(this);
+
+  listening_ = false;
+}
+
+void NetworkingPrivateEventRouter::OnListenerAdded(
+    const extensions::EventListenerInfo& details) {
+  // Start listening to events from the network state handler.
+  StartOrStopListeningForNetworkChanges();
+}
+
+void NetworkingPrivateEventRouter::OnListenerRemoved(
+    const extensions::EventListenerInfo& details) {
+  // Stop listening to events from the network state handler if there are no
+  // more listeners.
+  StartOrStopListeningForNetworkChanges();
+}
+
+void NetworkingPrivateEventRouter::StartOrStopListeningForNetworkChanges() {
+  EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router();
+  bool should_listen =
+      event_router->HasEventListener(
+          extensions::api::networking_private::OnNetworksChanged::kEventName) ||
+      event_router->HasEventListener(extensions::api::networking_private::
+                                         OnNetworkListChanged::kEventName);
+
+  if (!should_listen && listening_) {
+    scoped_refptr<NetworkingPrivateProcessClient> process_client(
+        NetworkingPrivateProcessClient::GetProcessClientForProfile(profile_));
+    process_client->ShutdownProcessClient();
+  }
+
+  listening_ = should_listen;
+}
+
+}  // namespace extensions