Base infrastructure for Networking Private API on Windows and Mac.

chrome/common/networking_private_messages.h

Index: chrome/common/networking_private_messages.h
diff --git a/chrome/common/networking_private_messages.h b/chrome/common/networking_private_messages.h
new file mode 100644
index 0000000000000000000000000000000000000000..5200ac899a8881550f74eb4fbbb523a2da00e4cd
--- /dev/null
+++ b/chrome/common/networking_private_messages.h
@@ -0,0 +1,103 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Multiply-included message file, so no include guard.
+
+#include <string>
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/values.h"
+#include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_platform_file.h"
+
+#define IPC_MESSAGE_START NetworkingPrivateMsgStart
+
+//------------------------------------------------------------------------------
+// Utility process messages:
+// These are messages from the browser to the utility process. They are handled
+// by NetworkingPrivateHandler.
+
+// Use WiFiServiceMock instead of WiFiService implementation in browser_tests.
+IPC_MESSAGE_CONTROL1(NetworkingPrivateMsg_SetUpForTest,
+                     base::DictionaryValue /* parameters */)
+
+// Get properties of the network with given GUID.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_GetProperties,
+                     int32, /* message_id */
+                     std::string /* network_guid */)
+
+// Set properties of the network with given GUID.
+IPC_MESSAGE_CONTROL3(NetworkingPrivateMsg_SetProperties,
+                     int32,       /* message_id */
+                     std::string, /* network_guid */
+                     base::DictionaryValue /* properties */)
+
+// Start connect to the network with given GUID.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_StartConnect,
+                     int32, /* message_id */
+                     std::string /* network_guid */)
+
+// Start disconnect from the network with given GUID.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_StartDisconnect,
+                     int32, /* message_id */
+                     std::string /* network_guid */)
+
+// Get list of visible networks.
+IPC_MESSAGE_CONTROL1(NetworkingPrivateMsg_GetVisibleNetworks,
+                     int32 /* message_id */)
+
+// Request new scan of the network.
+IPC_MESSAGE_CONTROL0(NetworkingPrivateMsg_RequestNetworkScan)
+
+//------------------------------------------------------------------------------
+// Utility process host messages:
+// These are messages from the utility process to the browser. They are handled
+// by NetworkingPrivateClient.
+
+// Reply when the utility process API call has returned an error.
+// |error_code| is a error code string.

[palmer, 2013/10/23 22:16:12]

Typo: "an error"

[mef, 2013/10/24 02:19:08]

Done.

+IPC_MESSAGE_CONTROL3(NetworkingPrivateMsg_API_Error,
+                     int32,       /* message_id */
+                     std::string, /* error_code, if any */

[palmer, 2013/10/23 22:16:12]

Much better to pass ints, and stringify the errors in the browser.

[mef, 2013/10/24 02:19:08]

I think Networking Private API already defines error as string, but I could pass
int to NetworkingPrivateProcessClient here and stringify it there. Should I?

+                     base::DictionaryValue /* error_data, if any */)
+
+// Reply when the utility process is done getting network properties.
+// |properties| are properties convertible to NetworkProperties API object.

[palmer, 2013/10/23 22:16:12]

Is it possible to send a NetworkProperties instead of a DictionaryValue?

[mef, 2013/10/24 02:19:08]

Probably, but why? That DictionaryValue is passed directly to extension,
so what would be the benefit of strong typing there? 
Besides, stevenjb@ has convinced me to replace all enums in NetworkProperties
with strings from onc_constants.h.

+IPC_MESSAGE_CONTROL3(NetworkingPrivateMsg_GetProperties_Succeeded,
+                     int32,       /* message_id */
+                     std::string, /* network_guid */
+                     base::DictionaryValue /* properties */)
+
+// Reply when the utility process has started connect to network.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_StartConnect_Succeeded,
+                     int32, /* message_id */
+                     std::string /* network_guid */)
+
+// Reply when the utility process has started disconnect from network.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_StartDisconnect_Succeeded,
+                     int32, /* message_id */
+                     std::string /* network_guid */)
+
+// Reply when the utility process is done setting network properties.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_SetProperties_Succeeded,
+                     int32, /* message_id */
+                     std::string /* network_guid */)
+
+// List of visible networks of particular type.
+IPC_MESSAGE_CONTROL2(NetworkingPrivateMsg_GetVisibleNetworksSucceeded,
+                     int32, /* message_id */
+                     base::ListValue /* Network list */)

[palmer, 2013/10/23 22:16:12]

Is this also a sequence of GUID strings? What is the reason for using ListValue
in some places and vector<string> in others?

[mef, 2013/10/24 02:19:08]

This is list of NetworkingProperties-like DictionaryValues.

+
+// Event generated when networks change is detected.
+// |network_guids| is list of std::string objects containing network guids of
+// networks that have changed.
+IPC_MESSAGE_CONTROL1(NetworkingPrivateMsg_NetworksChanged_Event,
+                     std::vector<std::string> /* list of network_guids */)
+
+// Event generated when list of visible networks is changed.
+// |network_guids| is list of std::string objects containing list of visible
+// networks' guids.
+IPC_MESSAGE_CONTROL1(NetworkingPrivateMsg_NetworkListChanged_Event,
+                     std::vector<std::string> /* list of network_guids */)