Generate MouseEnter/MouseLeave events between processes.

Generate MouseEnter/MouseLeave events between processes.

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035
Committed: https://crrev.com/89ed0412083300318a04a2d4302a77f4d8b76cc9
Cr-Commit-Position: refs/heads/master@{#418629}

[kenrb, 2016-08-17 15:46:58]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2016-08-17 15:52:00]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:51:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kenrb, 2016-08-17 20:29:04]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:29:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:52:09]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kenrb, 2016-08-18 19:52:47]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2016-08-18 20:38:08]

Description was changed from

==========
Generate MouseEnter/MouseLeave events between processes.

[WIP]

BUG=632035
==========

to

==========
Generate MouseEnter/MouseLeave events between processes.

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035
==========

[commit-bot: I haz the power, 2016-08-18 20:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:48:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kenrb, 2016-08-19 15:18:22]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 15:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 16:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 16:20:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kenrb, 2016-08-19 20:30:35]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 20:31:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 20:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 20:54:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kenrb, 2016-08-25 02:53:01]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 02:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 03:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 03:54:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kenrb, 2016-09-07 13:18:31]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:18:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 13:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 13:21:07]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kenrb, 2016-09-07 13:51:54]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:52:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 15:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:07:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kenrb, 2016-09-08 17:34:59]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 17:35:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2016-09-08 18:39:42]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:40:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2016-09-08 19:02:50]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:03:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:56:51]

Dry run: This issue passed the CQ dry run.

[kenrb, 2016-09-08 20:02:17]

kenrb@chromium.org changed reviewers:
+ nzolghadr@chromium.org

[kenrb, 2016-09-08 20:02:18]

nzolghadr: PTAL?

This CL implements what we discussed a few weeks ago, dispatching mouse events
to multiple processes in response to a MouseMove targeted to one. Would you mind
giving this a first review?

[Navid Zolghadr, 2016-09-09 14:27:41]

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:75: }
When do we call this destructor? Is it when the iframe is destructed? If so if I
have my mouse inside an inner iframe and the outer frame destroys the inner
iframe we reset the position of the mouse totally as if it is outside everything
instead of moving it to its parent. Right?

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:394:
transformed_point = root_view->TransformPointToCoordSpaceForView(
From the perspective of the common ancestor mouse has moved from one part of it
to another. Would sending a mousemove work the same as the case below?

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:408: //
incorrectly. See bug https://crbug.com/638364.
I did a few tests myself. I believe sending a mousemove seems correct. Because
Blink later does another hit-test and realized the mousemove is inside an iframe
and sends that event to that iframe. If that reference to that iframe somehow
knows it is not an in process iframe and blink cannot talk to that directly it
can just ignores that forwarding as the higher layer here already did that
forwarding for it.

[kenrb, 2016-09-12 17:44:15]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[kenrb, 2016-09-12 17:44:47]

Thanks for the review.

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:75: }
On 2016/09/09 14:27:41, Navid Zolghadr wrote:
> When do we call this destructor? Is it when the iframe is destructed? If so if
I
> have my mouse inside an inner iframe and the outer frame destroys the inner
> iframe we reset the position of the mouse totally as if it is outside
everything
> instead of moving it to its parent. Right?

Yes.

This is called when a RenderWidgetHostView is destroyed, which corresponds to
the iframe content going away (possibly because of a process crash). I've added
a change to try to change last_mouse_move_target_ to its parent when it is
destroyed, this isn't guaranteed to work in all cases (e.g. if the current
target is nested within another OOPIF, and the parent OOPIF process crashes).

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:394:
transformed_point = root_view->TransformPointToCoordSpaceForView(
On 2016/09/09 14:27:41, Navid Zolghadr wrote:
> From the perspective of the common ancestor mouse has moved from one part of
it
> to another. Would sending a mousemove work the same as the case below?

Changed.

https://codereview.chromium.org/2229463004/diff/260001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:408: //
incorrectly. See bug https://crbug.com/638364.
On 2016/09/09 14:27:41, Navid Zolghadr wrote:
> I did a few tests myself. I believe sending a mousemove seems correct. Because
> Blink later does another hit-test and realized the mousemove is inside an
iframe
> and sends that event to that iframe. If that reference to that iframe somehow
> knows it is not an in process iframe and blink cannot talk to that directly it
> can just ignores that forwarding as the higher layer here already did that
> forwarding for it.

Okay, this seems reasonable and I have changed the comment accordingly.

[commit-bot: I haz the power, 2016-09-12 17:44:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:05:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kenrb, 2016-09-12 20:56:27]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 20:57:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 22:44:14]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2016-09-14 14:51:46]

lgtm

https://codereview.chromium.org/2229463004/diff/300001/content/browser/render...
File content/browser/renderer_host/render_widget_host_input_event_router.cc
(right):

https://codereview.chromium.org/2229463004/diff/300001/content/browser/render...
content/browser/renderer_host/render_widget_host_input_event_router.cc:78:
static_cast<RenderWidgetHostViewChildFrame*>(last_mouse_move_target_)
nit: I guess the ideal solution is that target should be the first parent that
is not yet destroyed. But I'm not sure if we can get it from the sequence of
destroyed/crashed parents here or not. But either way that is an edge case. As
long as you keep it in mind that for later that would be enough.

[kenrb, 2016-09-14 17:56:44]

kenrb@chromium.org changed reviewers:
+ avi@chromium.org

[kenrb, 2016-09-14 17:56:45]

avi: PTAL for content owner review?

[Avi (use Gerrit), 2016-09-14 18:01:03]

lgtm

[kenrb, 2016-09-14 18:07:43]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:08:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:06:13]

Description was changed from

==========
Generate MouseEnter/MouseLeave events between processes.

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035
==========

to

==========
Generate MouseEnter/MouseLeave events between processes.

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035
==========

[commit-bot: I haz the power, 2016-09-14 19:06:14]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-09-14 19:09:27]

Description was changed from

==========
Generate MouseEnter/MouseLeave events between processes.

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035
==========

to

==========
Generate MouseEnter/MouseLeave events between processes.

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035

Committed: https://crrev.com/89ed0412083300318a04a2d4302a77f4d8b76cc9
Cr-Commit-Position: refs/heads/master@{#418629}
==========

[commit-bot: I haz the power, 2016-09-14 19:09:28]

Patchset 16 (id:??) landed as
https://crrev.com/89ed0412083300318a04a2d4302a77f4d8b76cc9
Cr-Commit-Position: refs/heads/master@{#418629}