Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2229463003: Make toPositionInFlatTree() to handle a position anchored by shadow root (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make toPositionInFlatTree() to handle a position anchored by shadow root This patch changes |toPositionInFlatTree()| to handle a position anchored by shadow root with position anchor type other than |OffsetInAnchor|. This patch is a preparation of http://crrev.com/2221783003, which attempt to call |toPositionInFlatTree()| with a position which uses |ShadowRoot| as anchor node. BUG=139552, 632333 TEST=run_webkit_unit_tests --gtest_filter=PositionTest.ToPositionInFlatTreeWithShadowRoot Committed: https://crrev.com/a6d7af3689ae51f9c41b68c500150a1648d20241 Cr-Commit-Position: refs/heads/master@{#410646}

Patch Set 1 : 2016-08-09T14:04:01 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/Position.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-09 07:19:23 UTC) #5
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-09 08:19:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229463003/1
4 years, 4 months ago (2016-08-09 09:31:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229463003/1
4 years, 4 months ago (2016-08-09 09:31:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 13:03:28 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 13:04:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6d7af3689ae51f9c41b68c500150a1648d20241
Cr-Commit-Position: refs/heads/master@{#410646}

Powered by Google App Engine
This is Rietveld 408576698