MD Settings: Ensure that "advanced sync page" is force rendered, only if applicable.

chrome/browser/resources/settings/people_page/people_page.html

Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index ac843ffc93607bf7c56cbbb4ffbebd8c7ad9bfe4..0e41e7b1ecb04235b8b25ba30498d88365fe9e2c 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -234,12 +234,14 @@
           </div>
         </template>
       </neon-animatable>
-      <template is="dom-if" name="sync">
-        <settings-subpage
-            associated-control="[[$$('#customize-sync')]]"
-            page-title="$i18n{syncPageTitle}">
-          <settings-sync-page></settings-sync-page>
-        </settings-subpage>
+      <template is="dom-if" if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]">

[dpapad, 2016/08/09 00:09:53]

See lines 129-132, where the element that triggers this subpage is also inside a
similar dom-if. Without this, the searching algorithm erroneously expands the
"advanced sync page" when it is not applicable (user is signed out), and an
assertion is thrown while searching by
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search....

+        <template is="dom-if" name="sync">
+          <settings-subpage
+              associated-control="[[$$('#customize-sync')]]"
+              page-title="$i18n{syncPageTitle}">
+            <settings-sync-page></settings-sync-page>
+          </settings-subpage>
+        </template>
       </template>
 <if expr="chromeos">
       <template is="dom-if" name="quick-unlock-authenticate" no-search>