Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2229413002: google_apis: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

google_apis: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/47684233b141700ac710afdff7fa08e6f121c725 Cr-Commit-Position: refs/heads/master@{#411629}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M google_apis/drive/request_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/account_tracker.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 16:52:05 UTC) #7
Roger Tawa OOO till Jul 10th
lgtm
4 years, 4 months ago (2016-08-11 23:45:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229413002/20001
4 years, 4 months ago (2016-08-12 12:27:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 13:06:57 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 13:10:16 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47684233b141700ac710afdff7fa08e6f121c725
Cr-Commit-Position: refs/heads/master@{#411629}

Powered by Google App Engine
This is Rietveld 408576698