Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2229403003: Revert of [heap] Switch to 500k pages (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Switch to 500k pages (patchset #24 id:780001 of https://codereview.chromium.org/2013713003/ ) Reason for revert: Failures on waterfall: e.g. http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11134 Original issue's description: > [heap] Switch to 500k pages > > - Decrease regular heap object size to 300k, keeping the same ration (60%) > between this limit and page size. > > In a follow up, we can now get rid of the new space border page while > keeping the 1M minimum new space size. > > Some results (v8.infinite_scroll; 3 runs): > - evacuate.avg: +15.3% (1.4->1.2) > - evacuate.max: +24.4% (2.4->1.8) > > BUG=chromium:581412 > LOG=N > R=hpayer@chromium.org, ulan@chromium.org, yangguo@chromium.org > > Committed: https://crrev.com/ffe5c670e1559d11e7b252e15fec38765e7dbe4f > Cr-Commit-Position: refs/heads/master@{#38533} TBR=hpayer@chromium.org,ulan@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Committed: https://crrev.com/555c961990088d545e2b475da3872bd63fa27569 Cr-Commit-Position: refs/heads/master@{#38537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -124 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 3 chunks +1 line, -7 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +9 lines, -56 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +12 lines, -4 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 4 chunks +67 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 3 chunks +7 lines, -17 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 2 chunks +11 lines, -19 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Lippautz
Created Revert of [heap] Switch to 500k pages
4 years, 4 months ago (2016-08-10 12:12:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229403003/1
4 years, 4 months ago (2016-08-10 12:12:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 12:12:54 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 12:13:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/555c961990088d545e2b475da3872bd63fa27569
Cr-Commit-Position: refs/heads/master@{#38537}

Powered by Google App Engine
This is Rietveld 408576698