net: Use stl utilities from the base namespace

net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
Committed: https://crrev.com/b8f60cacd31c35debe06dfff341d69c01834899c
Cr-Commit-Position: refs/heads/master@{#411615}

[Sami, 2016-08-10 10:29:22]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 10:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 11:41:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 11:41:41]

Dry run: This issue passed the CQ dry run.

[Sami, 2016-08-10 16:48:01]

Description was changed from

==========
net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

to

==========
net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

[Sami, 2016-08-10 16:48:02]

skyostil@chromium.org changed reviewers:
+ mef@chromium.org

[Sami, 2016-08-10 16:48:16]

PTAL.

[mef, 2016-08-11 16:09:04]

mef@chromium.org changed reviewers:
+ bnc@chromium.org, rch@chromium.org

[mef, 2016-08-11 16:09:05]

Changes lg tm, although I'm not clear about benefits of doing this. 
Is it consistency or something else?

Also, net/spdy and net/quic code is kept in sync with other codebases, and I'm
not sure whether adding these prefixes in chromium will inflict considerable
pain on that process.

Ryan and Bence, could you comment?

[Ryan Hamilton, 2016-08-11 18:35:10]

On 2016/08/11 16:09:05, mef wrote:
> Changes lg tm, although I'm not clear about benefits of doing this. 
> Is it consistency or something else?
> 
> Also, net/spdy and net/quic code is kept in sync with other codebases, and I'm
> not sure whether adding these prefixes in chromium will inflict considerable
> pain on that process.
> 
> Ryan and Bence, could you comment?

We can update our merge scripts to handle this. It's annoying that these files
live in a different namespace in chrome than they do internally. But c'est la
vie.

net/quic/ lgtm

[mef, 2016-08-11 18:44:13]

On 2016/08/11 18:35:10, Ryan Hamilton wrote:
> On 2016/08/11 16:09:05, mef wrote:
> > Changes lg tm, although I'm not clear about benefits of doing this. 
> > Is it consistency or something else?
> > 
> > Also, net/spdy and net/quic code is kept in sync with other codebases, and
I'm
> > not sure whether adding these prefixes in chromium will inflict considerable
> > pain on that process.
> > 
> > Ryan and Bence, could you comment?
> 
> We can update our merge scripts to handle this. It's annoying that these files
> live in a different namespace in chrome than they do internally. But c'est la
> vie.
> 
> net/quic/ lgtm

Thanks, Ryan! LGTM

[Bence, 2016-08-11 20:00:41]

LGTM.  It took me a while to figure out why the code compiles at all without
this CL, but then I found the temporary aliases at the bottom of
https://crrev.com/2221403002/diff/1/base/stl_util.h.

[Sami, 2016-08-12 10:54:50]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 10:55:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 12:16:39]

Dry run: This issue passed the CQ dry run.

[Sami, 2016-08-12 12:29:21]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-08-12 12:29:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org,
mef@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2229393003/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-08-12 12:29:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:34:58]

Description was changed from

==========
net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

to

==========
net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

[commit-bot: I haz the power, 2016-08-12 12:35:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 12:37:30]

Description was changed from

==========
net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

to

==========
net: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301

Committed: https://crrev.com/b8f60cacd31c35debe06dfff341d69c01834899c
Cr-Commit-Position: refs/heads/master@{#411615}
==========

[commit-bot: I haz the power, 2016-08-12 12:37:32]

Patchset 2 (id:??) landed as
https://crrev.com/b8f60cacd31c35debe06dfff341d69c01834899c
Cr-Commit-Position: refs/heads/master@{#411615}