Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2229393002: convert LayoutTest/scrollbars/rtl/* js-test.js tests to testharness.js based tests. (Closed)

Created:
4 years, 4 months ago by MuVen
Modified:
4 years, 4 months ago
Reviewers:
Srirama, skobes
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert LayoutTest/scrollbars/rtl/* js-test.js tests to testharness.js based tests. BUG=636285 Committed: https://crrev.com/3bf34c3dac6f4d91594c22c2bec6bb4cf63a65c1 Cr-Commit-Position: refs/heads/master@{#411295}

Patch Set 1 : converted js-test.js to testharness.js #

Total comments: 12

Patch Set 2 : addressed review comments #

Patch Set 3 : removed div-absolute-expected in virtual folder #

Messages

Total messages: 22 (13 generated)
MuVen
PTAL
4 years, 4 months ago (2016-08-10 10:26:10 UTC) #3
Srirama
LGTM with comments fixed and after approval from skobes. https://codereview.chromium.org/2229393002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html File third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html (right): https://codereview.chromium.org/2229393002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html#newcode2 third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html:2: ...
4 years, 4 months ago (2016-08-10 13:24:40 UTC) #7
skobes
lgtm
4 years, 4 months ago (2016-08-10 21:16:52 UTC) #8
MuVen
addressed comments, Committing the changes. https://codereview.chromium.org/2229393002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html File third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html (right): https://codereview.chromium.org/2229393002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html#newcode2 third_party/WebKit/LayoutTests/scrollbars/rtl/div-absolute.html:2: <head> On 2016/08/10 13:24:39, ...
4 years, 4 months ago (2016-08-11 07:05:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229393002/60001
4 years, 4 months ago (2016-08-11 07:32:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/275960)
4 years, 4 months ago (2016-08-11 08:57:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229393002/80001
4 years, 4 months ago (2016-08-11 09:07:49 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 4 months ago (2016-08-11 10:18:11 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 10:20:00 UTC) #22
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3bf34c3dac6f4d91594c22c2bec6bb4cf63a65c1
Cr-Commit-Position: refs/heads/master@{#411295}

Powered by Google App Engine
This is Rietveld 408576698