Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2229383004: PPC/s390: Use Variable::binding_needs_init() to determine hole initialization (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Use Variable::binding_needs_init() to determine hole initialization Port 6768456db513936cb19c8cdc657a7cd6122584a9 Original commit message: The old code was using VariableMode, but that signal is both over-pessimistic (some CONST and LET variables need no hole-initialization) and inconsistent with other uses of the InitializationFlag enum (such as %LoadLookupSlot). This changes no observable behavior, but removes unnecessary hole initialization and hole checks in a few places, including block-scoped function declarations, super property lookups, and new.target. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/04c51b214f99d3c77f7c7fc1d46ba2b29b9c63f5 Cr-Commit-Position: refs/heads/master@{#38551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -93 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 7 chunks +29 lines, -47 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 7 chunks +29 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-10 16:08:52 UTC) #1
john.yan
lgtm
4 years, 4 months ago (2016-08-10 16:22:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229383004/1
4 years, 4 months ago (2016-08-10 16:22:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 16:43:49 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:44:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04c51b214f99d3c77f7c7fc1d46ba2b29b9c63f5
Cr-Commit-Position: refs/heads/master@{#38551}

Powered by Google App Engine
This is Rietveld 408576698